Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the CI DB HOST to localhost #718

Closed
jwoertink opened this issue Dec 29, 2021 · 0 comments · Fixed by #719
Closed

Update the CI DB HOST to localhost #718

jwoertink opened this issue Dec 29, 2021 · 0 comments · Fixed by #719
Labels
good first issue Good for newcomers

Comments

@jwoertink
Copy link
Member

lucky_cli/src/web_app_skeleton/.github/workflows/ci.yml.ecr

Line 40 in 91d4149

DB_HOST: postgres

I'm pretty sure this line can just go away... Or it may have to be set to localhost... Basically, we used to run on actual Crystal containers and Github auto mapped postgres as the host to the service. Now we just run directly on the ubuntu-latest machine, so the host is just localhost.

Avram can be used as an example here too if need be.
https://github.com/luckyframework/avram/blob/9b184d4b586d783b096a5d377eafd98c78e32026/.github/workflows/ci.yml#L82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update GitHub workflow Postgre host to localhost robcole/lucky_cli
1 participant
@jwoertink