Route Globbing

[russ]

I have a route in Rails that uses globbing and an optional parameter. Would be great if this router would support these features. The sample route I have looks like this:

get '/track/:code(/*path)' => 'track#track'

[paulcsmith]

@russ can you provide a bit more info about how you use that route? What parameters you use, what the controller looks like, etc. I’m wondering if there are ways we can do it without a glob. And even if a glob is required it would be helpful to know the use case a bit better. Thanks so much for your input!

[russ]

We use it for a marketing tracking setup.

Most of the time the link is just /track/:code but people can use it for deep linking by passing in /track/:code/rest/of/path to get redirected to a specific location. Being able to capture that glob in a variable lets me do the redirect accordingly.

[paulcsmith]

Ah ok. That makes a lot of sense. If you were writing this from scratch, could it be done with a query param instead? Just trying to figure out possible options

[russ]

For sure if it was from scratch but I'm dealing with over a decade of legacy links at this point. :) I know this sort of feature can really make the routing logic complex.

[paulcsmith]

Ok that’s good to know. I ask because I try to prioritize things based on whether there is some kind of workaround or not. If it works for new apps, but not old ones that sucks but is better than not working ever.

I do want to make it so people can convert legacy apps to crystal though. I’ll keep this open. I have some ideas that might work while still maintaining speed and a clean code base

[russ]

Sounds good. I'll keep an eye on this. Really liking the feel of Lucky so far.

[paulcsmith]

I’m happy to hear that! Anything in particular that you like, or anything you’ve had trouble with? Just asking because it’s helpful for guiding the direction of Lucky and for figuring out what to highlight in blogs :)

[russ]

Nothing major yet. I noticed the guides were missing some stuff around extra settings around cookies. I plan on submitting a pull request for that soon.

As far as stuff I like it's just that thought that has gone into the setup. From the initial setup, the lucky -h output being clean, and the routes table printing nicely. It's really these small sorts of things that really give it polish. Keep up the good work. I hope to be able to contribute a bit as I get time.

[paulcsmith]

Thanks for the feedback! Polishing the experience is one of those unspoken goals I have for Lucky. I'm glad you noticed and enjoyed it. Feel free to hop in to https://gitter.im/luckyframework/Lobby if you have any questions or just want to chat

[robacarp]

The amber-router has this, and it wasn't a bad problem to solve. I haven't looked deeply at the way you're matching here, but the amber-router switches to attempt tail-first matching to accomplish glob routes, which might be a usable pattern here.

[paulcsmith]

@robacarp That sounds awesome. As long as performance is good, then this sounds like a nice idea!