Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Download Failure Dialog Box? #14

Open
photonometric opened this issue Sep 22, 2016 · 2 comments
Open

Remove Download Failure Dialog Box? #14

photonometric opened this issue Sep 22, 2016 · 2 comments

Comments

@photonometric
Copy link

When the plugin fails to retrieve a favicon—network error, website error, or if there simply isn't one—it supplies a wordy dialog with an OK button to explain the failure

keepass favicon error dialog

It seems to me that this is quite unnecessary. The process itself already takes over the UI stream. A simple self-closing popup or perhaps sentence in the status bar (if possible) would be more than adequate. No one expects every website to have a favicon, and this dialog belabors the point a little too much, I think.

@luckyrat
Copy link
Owner

No one expects every website to have a favicon

I'm not sure I'd go quite that far but totally agree that there are a majority of cases where the UI surrounding failure modes could be better and I would expect our options for UI controls are better now than 8 years ago.

I think the current implementation does the job though so I won't personally be prioritising work to improve this - although pull requests are welcome.

@darkdragon-001
Copy link

When this is removed (what I think is okay), then logging functionality should be introduced instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants