Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dropBufferSupport option to improve the performance #293

Merged
merged 6 commits into from
May 7, 2016
Merged

feat: add dropBufferSupport option to improve the performance #293

merged 6 commits into from
May 7, 2016

Conversation

luin
Copy link
Collaborator

@luin luin commented May 3, 2016 •
edited
Loading

@luin luin force-pushed the feat/drop-buffer-support branch from cb05340 to 789b322 Compare May 3, 2016 02:13
@luin luin force-pushed the feat/drop-buffer-support branch from 789b322 to 14cc39b Compare May 3, 2016 02:16
shaharmor
shaharmor reviewed May 3, 2016
View reviewed changes
test/functional/drop_buffer_support.js
});
});

it('should return strings correctly', function (done) {
Copy link
Collaborator

@shaharmor shaharmor May 3, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate from two tests below, did you mean to use dropBufferSupport: false?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test makes sure non-binary methods (get, set) works when dropBufferSupport is enabled.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah but there is another test that is exactly the same down below (Look at the last test)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha...you're right.
shame-LfFC2erYa5qN2

@luin luin force-pushed the feat/drop-buffer-support branch from 8cd7a8c to d7f6dce Compare May 3, 2016 12:54
@luin luin merged commit 1a8700c into master May 7, 2016
@luin luin deleted the feat/drop-buffer-support branch May 7, 2016 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luin @shaharmor