Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send_command is not a function #90

Closed
siddo420 opened this issue Jul 6, 2015 · 7 comments
Closed

send_command is not a function #90

siddo420 opened this issue Jul 6, 2015 · 7 comments

Comments

@siddo420
Copy link

siddo420 commented Jul 6, 2015

I am using metroplex node module that requires a redis connection. When I used ioredis, I got the following error whereas the default Redis client (that comes with metroplex) seems to work fine.

/node-web-projects/test3/node_modules/ioredis/node_modules/bluebird/js/main/async.js:43
        fn = function () { throw arg; };
                                 ^
TypeError: leverage._.client.send_command is not a function

Any ideas what send_command is and why it is not supported?

FYI: I am using iojs

@siddo420
Copy link
Author

siddo420 commented Jul 6, 2015

Looks like metroplex is using https://github.com/mranney/node_redis

@luin
Copy link
Collaborator

luin commented Jul 6, 2015

send_command is a private method in node_redis.

@siddo420
Copy link
Author

siddo420 commented Jul 6, 2015

Ok, so you're saying that metroplex is dependent on that particular node module because of the function/method it uses.

Any chance ioredis would implement a function/feature like that?

@luin
Copy link
Collaborator

luin commented Jul 6, 2015

Well, I checked the documentation of node_redis again and it turns out send_command is a public method since it's documented here. I'm going to implement it in ioredis.

BTW, Where does metroplex use send_command method? I just checked it out and didn't find it.

@siddo420
Copy link
Author

siddo420 commented Jul 6, 2015

Looks like metroplex is using a Redis wrapper named leverage (https://www.npmjs.com/package/leverage) around redis client and that wrapper is using send_command.

I used the following command to list all instances where send_command is used in both leverage and redis client.

egrep -ir "send_command" node_modules/metroplex/

@luin luin closed this as completed in 2edc5d1 Jul 6, 2015
@luin
Copy link
Collaborator

luin commented Jul 6, 2015

Added in 1.5.10

@3rd-Eden
Copy link

3rd-Eden commented Jul 7, 2015

Thank you (I'm the author of leverage, metroplex).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants