Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this still being maintained? #122

Open
amimas opened this issue Feb 8, 2019 · 9 comments
Open

Is this still being maintained? #122

amimas opened this issue Feb 8, 2019 · 9 comments

Comments

@amimas
Copy link

amimas commented Feb 8, 2019

Just want to know if this is a stale project.

@amimas
Copy link
Author

amimas commented Feb 17, 2019

@lukeapage - would you be able to provide a quick update? It's understandable if you don't have the bandwidth to maintain this project. Maybe others can help with the maintenance.

@lukeapage
Copy link
Owner

Hi, not really.. the problem is I don’t use it. @robatwilliams also has permission to merge as I believe they use it

@robatwilliams
Copy link
Collaborator

It is in use by the company I work for, as part of our website's publishing toolchain. While that toolchain is in regular use, it's "done" and working - not undergoing development at the moment. If an issue arises in this project that affects that toolchain, it'd probably be seen to fairly quickly.

If there's anything in particular that needs fixing, I'd be happy to try and find if we have someone who's not busy and who would be able to merge any PRs and do a release.

@dialex
Copy link
Contributor

dialex commented Sep 19, 2019

@robatwilliams @lukeapage Hi there, there's something that needs fixing, yes, a moderate security flaw was discovered on marked, a dependency of this project. Please update it to v0.7.0.

Would it help if I made a PR? Here's the PR that fixes it. Can one of you review/merge it?

@robatwilliams
Copy link
Collaborator

Hi, thanks for bringing this up. I'm not the owner of the repo, so didn't receive a security notification from GitHub.

We specify ^0.3.5, anyone installing it will get 0.7.0 so I'm not sure this is much of a concern for this project. Correct me if I'm wrong. So I don't see reason to do a release right now. Thanks for the PR.

I see there have been many breaking changes to marked since the 0.3.5 version that was originally installed in this project. I'm not sure how significant they are, given that the project isn't using semantic versioning.

@dialex

This comment has been minimized.

@robatwilliams
Copy link
Collaborator

Let's continue this discussion on the PR, as it's not the subject of this issue.

@armano2
Copy link

armano2 commented Dec 22, 2019

hi, i did some work on updating all dependencies, and migrating some code, and overall cleanup

#135

some of tests on master do not work (due to weird usage of promises)


recently we started using it at typescript-eslint and i'd like to hear some feedback about my changes.

@jeffgore00
Copy link

Just FYI, I found what appears to be a maintained library that matches the functionality of this one:
https://www.npmjs.com/package/spellchecker-cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants