-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed class Object assign. #31
Conversation
Removed unnecessary hasOwnProperty.
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 115 115
=========================================
Hits 115 115
Continue to review full report at Codecov.
|
Hi, please remove all code style changes. I can look at the diff after irrelevant changes have been removed. |
Done it. |
@lukeed, if you want I can do the tests using |
No thank you. I'll review this over the weekend, sorry for the delay. Waiting because I'm pretty sure there was a reason |
Ok, hope you can find a solution for this one, using the x instead of tmp fix the problem for me at least... by the way, i created a new test for Object.assign in this one. Use it in your tests to fix the Object.assign please, i use it a lot. |
Any update? |
Would also love for this PR to get merged 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally caught a second to review this & verify that it works as expected.
Thank you for the PR and for your patience on this 😃 Much appreciated!
When we clone a class that uses Object.assign the cloning result is different.
This PR fixes it by removing the hasOwnProperty check. This PR fixes it by checking if the property exists in the original object.See #30 (comment) and #30 (comment)