Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clients can cause the server to crash using malformed URLs #54

Closed
pR0Ps opened this issue Mar 20, 2020 · 1 comment
Closed

Clients can cause the server to crash using malformed URLs #54

pR0Ps opened this issue Mar 20, 2020 · 1 comment
Labels

Comments

@pR0Ps
Copy link
Contributor

pR0Ps commented Mar 20, 2020

Found in v0.4.5, seems to be fixed in the next branch.

To reproduce:

  1. Run npx sirv start
  2. Visit http://localhost:5000/%

Traceback:

/<redacted>/node_modules/sirv/index.js:81
			let stats, file, uri=decodeURIComponent(req.path || req.pathname || parser(req).pathname);
			                     ^

URIError: URI malformed
    at decodeURIComponent (<anonymous>)
    at Server.cc (/<redacted>/node_modules/sirv/index.js:81:25)
    at Server.emit (events.js:327:22)
    at parserOnIncoming (_http_server.js:789:12)
    at HTTPParser.parserOnHeadersComplete (_http_common.js:116:17)
@lukeed lukeed added the has fix label May 4, 2020
@lukeed
Copy link
Owner

lukeed commented Jun 10, 2020

Closed via #64

@lukeed lukeed closed this as completed Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants