Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various bugs in current development version, mostly related to /setup #184

Closed
tastendruecker123 opened this issue Aug 20, 2022 · 6 comments · Fixed by #220
Closed

Various bugs in current development version, mostly related to /setup #184

tastendruecker123 opened this issue Aug 20, 2022 · 6 comments · Fixed by #220
Labels
bug Something isn't working fixed dev fixed

Comments

@tastendruecker123
Copy link
Contributor

-JS function checkSerial() in setup.html is not present and leads to JS errors in browser
-Bad MQTT broker hostname in settings leads to mqtt.h making ~1000 connection attempts per second to the non-working host
-Buffer arrays not being initialized properly in various places (search code for '{0}')
-Inverter address cannot be shortened once configured. Attempting to change it from 3823398298 to 382 results in 3820000000 being stored.
-Several parameters cannot be deleted or are not being stored properly when they're empty (inverter name, active power limit and all MQTT parameters for example).

@DanielR92
Copy link
Collaborator

I make a PR for the first line, I check that with web.browser error and can confirm it. The function is not exist. - Thanks

@tastendruecker123
Copy link
Contributor Author

Lovely. This should take care of bug #1.

@lumapu
Copy link
Owner

lumapu commented Aug 21, 2022

what do you mean by 'bad broker host name'? A non existing host or an empty field?

@tastendruecker123
Copy link
Contributor Author

A host that doesn't resolve like "test".

@lumapu
Copy link
Owner

lumapu commented Aug 30, 2022

Buffer arrays not being initialized properly in various places (search code for '{0}')

done.

@stefan123t stefan123t added the ESP ESP8266 / ESP32 related label Sep 2, 2022
@aschiffler aschiffler linked a pull request Sep 4, 2022 that will close this issue
@stefan123t
Copy link
Collaborator

  1. checkSerial was fixed
  2. MQTT broker name flood control has been implemented as MQTT reconnect delay, fixed ESP32 build #194
  3. buffer arrays have been implemented
  4. overwriting old values in setup ?
  5. delete or store empty values in setup ?

@aschiffler is 4 and 5 fixed in the EEPROM class too, ie can we overwrite parts of the settings now ?

@stefan123t stefan123t added fixed dev fixed and removed ESP ESP8266 / ESP32 related labels Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed dev fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants