Skip to content
This repository has been archived by the owner on Jul 23, 2022. It is now read-only.

✨ Deprecate Docker images in favor of Deno's task runner #31

Open
x80486 opened this issue Apr 2, 2022 · 3 comments
Open

✨ Deprecate Docker images in favor of Deno's task runner #31

x80486 opened this issue Apr 2, 2022 · 3 comments
Assignees

Comments

@x80486
Copy link
Collaborator

x80486 commented Apr 2, 2022

While the Docker images could be convenient, with the insertion of Deno's task runner, recent versions of Lume are able to use instead the execute without install option.

Basically, the deno.json configuration file could be used with Lume as well:

{
  "tasks": {
    "build": "deno run -A https://deno.land/x/lume@v1.7.0/ci.ts",
    "serve": "deno task build -- --serve"
  }
}

In that sense, the version is always contained within the project, and all that's needed is to have a recent/compatible Deno version in the path.

@x80486 x80486 self-assigned this Apr 2, 2022
@x80486 x80486 pinned this issue Apr 2, 2022
@oscarotero
Copy link
Member

I'm agree. Deno tasks is pretty recent and yet unstable. I'm not sure when it will be stabilized, but I think after a couple of versions (deno 1.22) we could deprecate Docker image.

@x80486
Copy link
Collaborator Author

x80486 commented May 27, 2022

What do you think about generating these only for Lume versions 1.x?

I was thinking that once Lume reaches 2.x, every user should be aware of Deno tasks, and really the Docker images makes no sense at that point.

I will be maintaining these if you plan to maintain a 1.x branch — or something around those lines.

@oscarotero
Copy link
Member

Yes, I like it. I'm not sure when Lume will have a 2.0 version, maybe when Deno reaches to 2.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants