Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calibration: expose diode calibration #694

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JoepVanlier
Copy link
Member

@JoepVanlier JoepVanlier commented Sep 26, 2024

Why this PR?

  • This gives users an option to interrogate the parameter values and results of the diode calibration.
  • After discussing this with hrishi, I have decided to return a small dataclass rather than expose direct access to the free function to ensure that we can change this model in the future if need be.

Docs build here: https://lumicks-pylake.readthedocs.io/en/expose_diode_model/_api/lumicks.pylake.calibration.ForceCalibrationItem.html#lumicks.pylake.calibration.ForceCalibrationItem.diode_calibration

This gives users an option to interrogate the parameter values and results of the diode calibration
Copy link
Member

@tiagobonetti tiagobonetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good.
Maybe a more scientific review should be added still.

Comment on lines 160 to 161
simulation.simulate_diffusive_tracks No newline at end of file
simulation.simulate_diffusive_tracks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is GitHub tripping?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a newline at the end of the file 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants