fix: semantic

.eslintignore

@@ -1,4 +1,5 @@
 **/*.js
 **/*.test.*s
 src/**/jsonSortify.ts
-src/**/xmlToJson.ts
+src/**/xmlToJson.ts
+src/**/logsInstrumentation.ts

src/hooks/express.ts

@@ -17,11 +17,13 @@ export const ExpressHooks: InstrumentationIfc<ExpressRequestType, any> = {
     res.send = function (data: any) {
       response = data;
       res.send = oldResSend;
+      // eslint-disable-next-line prefer-rest-params
       return oldResSend.apply(res, arguments);
     };
     res.end = function () {
       diag.debug('opentelemetry-instrumentation-express on end()');
       return safeExecute(() => {
+        // eslint-disable-next-line prefer-rest-params
         const origRes = oldResEnd.apply(res, arguments);
         if (res.getHeaders())
           span.setAttribute('http.response.headers', JSON.stringify(res.getHeaders()));

src/hooks/http.ts

@@ -5,6 +5,7 @@ import { InstrumentationIfc } from './hooksIfc';
 import { isAwsService, runOneTimeWrapper, safeExecute } from '../utils';
 import { getAwsServiceData } from '../spans/awsSpan';
 
+// eslint-disable-next-line @typescript-eslint/no-empty-function
 const noop = () => {};
 
 const isFunctionAlreadyWrapped = (fn) => fn && fn.__wrapped;
@@ -43,7 +44,7 @@ const createEmitResponseOnEmitBeforeHookHandler = (
   span: Span & { attributes: Record<string, string> }
 ) => {
   let body = '';
-  let maxPayloadSize = MAX_SIZE;
+  const maxPayloadSize = MAX_SIZE;
   return function (args) {
     const { headers, statusCode } = response;
     if (args[0] === 'data' && body.length < maxPayloadSize) {
@@ -95,8 +96,10 @@ export const extractBodyFromEmitSocketEvent = (socketEventArgs) => {
       ) {
         const httpMessage = socketEventArgs._httpMessage;
         let lines = [];
+        // eslint-disable-next-line no-prototype-builtins
         if (httpMessage.hasOwnProperty('outputData')) {
           lines = httpMessage.outputData[0]?.data.split('\n') || [];
+          // eslint-disable-next-line no-prototype-builtins
         } else if (httpMessage.hasOwnProperty('output')) {
           lines = httpMessage.output[0]?.split('\n') || [];
         }
@@ -208,7 +211,7 @@ export const HttpHooks: InstrumentationIfc<
           headers: {},
         },
       };
-      let headers = getRequestHeaders(request);
+      const headers = getRequestHeaders(request);
       requestData.request.host = span?.attributes && span.attributes['http.host'];
       if (headers) {
         requestData.request.headers = headers;

src/instrumentros/LumigoHttpInstrumentation.ts

@@ -1,6 +1,6 @@
 import { HttpHooks } from '../hooks/http';
 
-const { HttpInstrumentation } = require('@opentelemetry/instrumentation-http');
+import { HttpInstrumentation } from "@opentelemetry/instrumentation-http";
 import axios, { AxiosResponse } from 'axios';
 import { LUMIGO_ENDPOINT } from '../wrapper';
 

src/utils.ts

@@ -4,8 +4,8 @@ import { sortify } from './tools/jsonSortify';
 
 export function safeExecute<T>(
   callback: Function,
-  message: string = 'Error in Lumigo tracer',
-  logLevel: string = 'warn',
+  message = 'Error in Lumigo tracer',
+  logLevel = 'warn',
   defaultReturn: T = undefined
 ): Function {
   return function (...args) {
@@ -31,7 +31,7 @@ export const runOneTimeWrapper = (func: Function, context: any = undefined): Fun
 
 export const safeGet = (obj, arr, dflt = null) => {
   let current = obj;
-  for (let i in arr) {
+  for (const i in arr) {
     if (!current) {
       return dflt;
     }
@@ -54,7 +54,7 @@ export const isAwsService = (host, responseData = undefined): boolean => {
 export const parseQueryParams = (queryParams) => {
   return safeExecute(() => {
     if (typeof queryParams !== 'string') return {};
-    let obj = {};
+    const obj = {};
     queryParams.replace(
       /([^=&]+)=([^&]*)/g,
       // @ts-ignore

src/wrapper.ts

@@ -3,11 +3,11 @@ import { diag, DiagConsoleLogger, DiagLogLevel } from '@opentelemetry/api';
 // And optionally change the logging level (Defaults to INFO)
 import LumigoHttpInstrumentation from './instrumentros/LumigoHttpInstrumentation';
 import LumigoExpressInstrumentation from './instrumentros/LumigoExpressInstrumentation';
-const { NodeTracerProvider } = require('@opentelemetry/sdk-trace-node');
-const { BatchSpanProcessor } = require('@opentelemetry/sdk-trace-base');
-const { registerInstrumentations } = require('@opentelemetry/instrumentation');
-const { Resource } = require('@opentelemetry/resources');
-const { CollectorTraceExporter } = require('@opentelemetry/exporter-collector');
+import { NodeTracerProvider } from "@opentelemetry/sdk-trace-node";
+import { BatchSpanProcessor } from "@opentelemetry/sdk-trace-base";
+import { registerInstrumentations } from "@opentelemetry/instrumentation";
+import { Resource } from "@opentelemetry/resources";
+import { CollectorTraceExporter } from "@opentelemetry/exporter-collector";
 const logLevel =
   (process.env.LUMIGO_DEBUG || 'false').toLowerCase() === 'true'
     ? DiagLogLevel.ALL
@@ -17,6 +17,7 @@ export const LUMIGO_ENDPOINT =
   'http://lumigo-wrapper-collector.golumigo.com:55681/v1/trace' || process.env.LUMIGO_ENDPOINT;
 
 export const getTracerInfo = (): { name: string; version: string } => {
+  // eslint-disable-next-line @typescript-eslint/no-var-requires
   const pkg = require('../package.json');
   const { name, version } = pkg;
   return { name, version };
@@ -40,6 +41,7 @@ const trace = (lumigoToken: string, serviceName: string, endpoint = LUMIGO_ENDPO
       return;
     }
     const exporter = new CollectorTraceExporter({
+    // @ts-ignore
       serviceName,
       url: endpoint,
     });
@@ -59,7 +61,9 @@ const trace = (lumigoToken: string, serviceName: string, endpoint = LUMIGO_ENDPO
 
     registerInstrumentations({
       instrumentations: [
+        // @ts-ignore
         new LumigoHttpInstrumentation(lumigoToken, endpoint),
+        // @ts-ignore
         new LumigoExpressInstrumentation(),
       ],
     });
@@ -86,6 +90,6 @@ module.exports = {
   LumigoExpressInstrumentation,
   LumigoInstrumentations: (lumigoToken?: string) => [
     new LumigoHttpInstrumentation(lumigoToken),
-    new LumigoExpressInstrumentation(lumigoToken),
+    new LumigoExpressInstrumentation(),
   ],
 };