fix: add missing dependencies (#423)

lumigo-io · Jul 3, 2024 · 9c69180 · 9c69180
1 parent 1c91026
commit 9c69180
Show file tree

Hide file tree

Showing 33 changed files with 2,050 additions and 174 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -25,62 +25,49 @@ workflows:
 
     - lumigo-orb/is_environment_available:
         context: common
-        skip_on_auto_test_update: true
         filters:
           branches:
             ignore: main
 
     - lumigo-orb/be-deploy:
         context: common
-        skip_on_auto_test_update: true
+        save_project_folder: false
         requires:
           - lumigo-orb/is_environment_available
 
-    - lumigo-orb/pre_build_artifacts:
+    - lumigo-orb/prep-it-resources:
         context: common
-        skip_on_auto_test_update: true
         requires:
           - lumigo-orb/is_environment_available
 
-    - lumigo-orb/integration-test-prep:
+    - lumigo-orb/prep-k8s-and-operator:
         context: common
-        pre_builds_available: true
-        run_test_cleanup: false
-        skip_on_auto_test_update: true
         requires:
-          - lumigo-orb/be-deploy
-          - lumigo-orb/pre_build_artifacts
-
-    - lumigo-orb/integration-test-cleanup:
-        name: pre-test-cleanup
-        context: common
-        skip_on_auto_test_update: true
-        requires:
-          - lumigo-orb/integration-test-prep
+          - lumigo-orb/is_environment_available
 
     - lumigo-orb/integration-test-parallel:
         context: common
         run_test_cleanup: false
-        skip_on_auto_test_update: true
         requires:
-          - pre-test-cleanup
+          - lumigo-orb/be-deploy
+          - lumigo-orb/prep-it-resources
+          - lumigo-orb/prep-k8s-and-operator
 
     - lumigo-orb/integration-test-cleanup:
         name: post-test-cleanup
         context: common
-        skip_on_auto_test_update: true
         requires:
           - lumigo-orb/integration-test-parallel
 
     - lumigo-orb/e2e-test:
         context: common
-        skip_on_auto_test_update: true
         requires:
-          - pre-test-cleanup
+          - lumigo-orb/be-deploy
+          - lumigo-orb/prep-it-resources
+          - lumigo-orb/prep-k8s-and-operator
 
     - lumigo-orb/workflow-completed-successfully:
         context: common
-        skip_on_auto_test_update: true
         requires:
           - test
           - lumigo-orb/integration-test-parallel

diff --git a/.eslintrc.js b/.eslintrc.js
@@ -8,6 +8,8 @@ module.exports = {
     'plugin:@typescript-eslint/eslint-recommended',
     'plugin:@typescript-eslint/recommended',
     'prettier',
+    'plugin:import/recommended',
+    'plugin:import/typescript'
   ],
   rules: {
     '@typescript-eslint/ban-ts-comment': 'off',
@@ -41,5 +43,6 @@ module.exports = {
     'no-console': 'off',
     'ban-types': 'off',
     'no-case-declarations': 'off',
+    'import/no-extraneous-dependencies': 'error'
   },
 };
diff --git a/.github/workflows/push-actions.yml b/.github/workflows/push-actions.yml
@@ -9,7 +9,7 @@ jobs:
     strategy:
       fail-fast: false # We don't want linting to prevent unit testing
       matrix:
-        npm-task: ['prettier:ci', 'lint', 'test:unit']
+        npm-task: ['prettier:ci', 'lint', 'test:unit', 'build']
     steps:
       - uses: actions/checkout@v4
       - name: Set up Node
@@ -22,7 +22,7 @@ jobs:
       - run: npm run ${{ matrix.npm-task }}
       - name: Upload distro as artifact
         uses: actions/upload-artifact@v4
-        if: ${{ matrix.npm-task == 'test:unit' }}
+        if: ${{ matrix.npm-task == 'build' }}
         with:
           name: distro-package
           path: distro.tgz
@@ -84,6 +84,7 @@ jobs:
           architecture: x64
       - name: Download distro
         uses: actions/download-artifact@v4
+        continue-on-error: true  # when there aren't changes the artifact won't be uploaded and this step will fail
         with:
           name: distro-package
       - run: npm i ./distro.tgz