feat: implement finer granularity to LUMIGO_SECRET_MASKING_REGEX #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be rebased after #172 is merged |
added 5 commits
May 7, 2023 12:25
Support finer-grained secret scrubbing via the following env vars: * LUMIGO_SECRET_MASKING_REGEX_HTTP_REQUEST_BODIES * LUMIGO_SECRET_MASKING_REGEX_HTTP_REQUEST_HEADERS * LUMIGO_SECRET_MASKING_REGEX_HTTP_QUERY_PARAMS * LUMIGO_SECRET_MASKING_REGEX_HTTP_RESPONSE_BODIES * LUMIGO_SECRET_MASKING_REGEX_HTTP_RESPONSE_HEADERS * LUMIGO_SECRET_MASKING_REGEX_ENVIRONMENT The environment variables above, as well as the already-supported LUMIGO_SECRET_MASKING_REGEX, accept the special value `all`, which makes the entire applicable payload to be scrubbed.
[skip ci]
GuyMoses
approved these changes
May 8, 2023
doriaviram
pushed a commit
that referenced
this pull request
May 8, 2023
# [1.21.0](v1.20.0...v1.21.0) (2023-05-08) ### Features * implement finer granularity to LUMIGO_SECRET_MASKING_REGEX ([#164](#164)) ([0a34d7c](0a34d7c))
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce environment variables to specify Lumigo secret masking at finer granularity:
LUMIGO_SECRET_MASKING_REGEX_HTTP_REQUEST_BODIESapplies secret redaction to HTTP request bodiesLUMIGO_SECRET_MASKING_REGEX_HTTP_REQUEST_HEADERSapplies secret redaction to HTTP request headersLUMIGO_SECRET_MASKING_REGEX_HTTP_QUERY_PARAMSapplies secret redaction to HTTP query parametersLUMIGO_SECRET_MASKING_REGEX_HTTP_RESPONSE_BODIESapplies secret redaction to HTTP response bodiesLUMIGO_SECRET_MASKING_REGEX_HTTP_RESPONSE_HEADERSapplies secret redaction to HTTP response bodiesLUMIGO_SECRET_MASKING_REGEX_ENVIRONMENTapplies secret redaction to process environment variables (that is, the content ofprocess.env)Also, add support to
LUMIGO_SECRET_MASKING_REGEXand all the env vars listed above for the specialallvalue, which will redact every value.