Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: extract framework correctly #82

Merged

Conversation

OrrLumigo
Copy link
Contributor

No description provided.

Copy link
Contributor

@mmanciop mmanciop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is trying to do too many things. What we need to do at first is just to verify whether the Express.js instrumentation is applied before creating the resource, and set framework accordingly. What this patch does is to go and add more API via env vars to enable and disable instrumentations and I do not think it makes sense for now.

jest.component.setup.js Outdated Show resolved Hide resolved
src/wrapper.ts Outdated Show resolved Hide resolved
src/wrapper.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@nirLumigo nirLumigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :)

src/wrapper.ts Outdated Show resolved Hide resolved
test/component/http/package.json Outdated Show resolved Hide resolved
test/basic.compatibility.test.ts Outdated Show resolved Hide resolved
test/instrumentationsTests/http.ts Outdated Show resolved Hide resolved
@OrrLumigo OrrLumigo requested a review from mmanciop August 17, 2022 07:22
jest.component.setup.js Outdated Show resolved Hide resolved
scripts/install_component.sh Outdated Show resolved Hide resolved
src/wrapper.ts Show resolved Hide resolved
test/instrumentationsTests/http.ts Outdated Show resolved Hide resolved
test/instrumentationsTests/http.ts Outdated Show resolved Hide resolved
@OrrLumigo OrrLumigo merged commit ce1cd8b into main Aug 17, 2022
@OrrLumigo OrrLumigo deleted the RD-8918-differentiate-nodejs-express-instrumentation-lib branch August 17, 2022 16:24
doriaviram pushed a commit that referenced this pull request Aug 17, 2022
## [1.1.1](v1.1.0...v1.1.1) (2022-08-17)

### Bug Fixes

* extract framework correctly ([#82](#82)) ([ce1cd8b](ce1cd8b))
@doriaviram
Copy link
Contributor

🎉 This PR is included in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants