-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: extract framework correctly #82
fix: extract framework correctly #82
Conversation
* fix: fix semantic release deploy
* fix: fix semantic release deploy
…n all Node versions
…oupdate # Conflicts: # README.md
…oupdate # Conflicts: # src/wrapper.ts
…oupdate # Conflicts: # scripts/update_supported_packages_documentation.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change is trying to do too many things. What we need to do at first is just to verify whether the Express.js instrumentation is applied before creating the resource, and set framework
accordingly. What this patch does is to go and add more API via env vars to enable and disable instrumentations and I do not think it makes sense for now.
…e-nodejs-express-instrumentation-lib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! :)
## [1.1.1](v1.1.0...v1.1.1) (2022-08-17) ### Bug Fixes * extract framework correctly ([#82](#82)) ([ce1cd8b](ce1cd8b))
🎉 This PR is included in version 1.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.