Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds markdown parser context #285

Merged
merged 2 commits into from
Jan 19, 2019
Merged

Adds markdown parser context #285

merged 2 commits into from
Jan 19, 2019

Conversation

patriksvensson
Copy link
Sponsor Contributor

Closes #284

@patriksvensson
Copy link
Sponsor Contributor Author

patriksvensson commented Jan 12, 2019

I've added the new context parameter to the methods I thought made sense in Markdown.cs (the methods that also took an optional markdown pipeline), but would want some feedback on whether or not this is correct or not.

/// <summary>
/// Gets or sets the context property collection.
/// </summary>
public IDictionary<object, object> Properties { get; set; }
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can expose only a Dictionary<object, object>, not a IDictionary and remove also the setter.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, forgot that I can do that right away from github, so simple 😅

@xoofx xoofx merged commit f8df3c8 into xoofx:master Jan 19, 2019
@xoofx
Copy link
Owner

xoofx commented Jan 19, 2019

Thanks!

@patriksvensson patriksvensson deleted the feature/GH-284 branch January 19, 2019 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants