Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a few small optimizations in
RendererBase
.It uses some recent C# features, such as pattern matching, to make the code more readable.
It does not changes the semantics of the code. In fact, I believe that the
Write(MarkdownObject obj)
method contains abug, and this PR does not attempt to fix it.To understand why there may be a bug here, consider this block of code:
Notice how renderersPerType caches renderers based on the type of the MarkdownObject, whereas the
IMarkdownObjectRenderer.Accept(RendererBase renderer, MarkdownObject obj)
method takes an actual MarkdownObject as a parameter, not just its type.The easiest fix would be to change that method signature. Unfortunately, renderers exist that test instance property values in that method, e.g.
NormalizeAutoLinkRenderer
.