Enable nullable annotations, round 2 of x #524
Conversation
|
I had to merge another PR in the meantime and there are a few merge conflicts, could you have a look? |
| @@ -59,7 +61,7 @@ public override bool Match(InlineProcessor processor, ref StringSlice slice) | |||
| var position = processor.GetSourcePosition(slice.Start, out int globalLineIndex, out int column); | |||
| var localLineIndex = globalLineIndex - processor.LineIndex; | |||
|
|
|||
| if (tableState == null) | |||
| if (tableState is null) | |||
There was a problem hiding this comment.
I don't mind these changes (personally prefer is/is not), but it doesn't make a difference for nullable analyzers right?
There was a problem hiding this comment.
The analyzers pick up both patterns, but is is slightly more correct as it bypasses the equality operator and prevents use on structs. I'd like to followup with another PR after this to replace the remaining == null with is null / for consistency.
| @@ -60,11 +61,11 @@ protected ParserList(IEnumerable<T> parsersArg) : base(parsersArg) | |||
| var tempCharMap = new Dictionary<char, T[]>(); | |||
| foreach (var parser in this) | |||
| { | |||
| if (parser.OpeningCharacters != null && parser.OpeningCharacters.Length != 0) | |||
| if (parser.OpeningCharacters is { Length: > 0 }) | |||
There was a problem hiding this comment.
We should stay consistent with the type of checks. The same pattern is used above in the same method but wasn't changed.
There was a problem hiding this comment.
Agreed. I had planned to follow up to apply these changes everywhere, but didn't want this PR to become to big. I replaced the remaining instances of this pattern to address this feedback now.
|
Thanks, I think this is great for Markdig. Even if we might end up with a ton of |
|
Ready for review. We'll likely want to refactor ReferralLinksExtension to make it's list non-null to address a possible NRE, but am avoiding functional changes in this first round. |
|
Notable, they'll likely be at least one remaining round to enable the next batch of files. After that, we should be able to enable nullable at the project level, and remove the inline #nullable enables. |
|
Thanks! |
Round 2