JiraLinkInlineParser.cs - Make digits in JiraKey's posible #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MihaZupan
approved these changes
May 3, 2021
There was a problem hiding this comment.
Thanks! Could you please also add a test for this case?
Adding an example here: https://github.com/xoofx/markdig/blob/master/src/Markdig.Tests/Specs/JiraLinks.md
And then re-running the SpecFileGen project
| @@ -41,7 +41,7 @@ public override bool Match(InlineProcessor processor, ref StringSlice slice) | |||
| var endKey = slice.Start; | |||
|
|
|||
| //read as many uppercase characters as required - project key | |||
There was a problem hiding this comment.
Suggested change
| //read as many uppercase characters as required - project key | |
| // read as many uppercase characters or digits as required - project key |
There was a problem hiding this comment.
Hi, I see everything is added for the test en verified.
I've added a test to check if the first char in the key is not a digit as this is not allowed by Jira.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A digit can also be part of the project key for example T3ST is a valid project key and T3ST-123 is thus a valid Jira issue number but it will not be recognized by this tool.
I propose to add an OR IsDigit() check like: 'while (current.IsAlphaUpper() || current.IsDigit())'
Thanks for considering to update.