Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate "device is already open" error and other improvements from ledger refactor #21

Open
faboweb opened this issue Jan 7, 2020 · 2 comments
Open

Translate "device is already open" error and other improvements from ledger refactor #21

faboweb opened this issue Jan 7, 2020 · 2 comments

Comments

@faboweb
Copy link
Contributor

faboweb commented Jan 7, 2020

This error happens when the ledger connection wasn't removed before. This should be translated into "Couldn't access Ledger, please refresh browser". Or try to handle it and clear an existing connection.
@jbibla jbibla changed the title Translate "device is already open" error Translate "device is already open" error and other improvements from ledger refactor Jan 14, 2020
@jbibla jbibla mentioned this issue Jan 14, 2020
Merged
5 tasks
@jbibla
Copy link
Contributor

jbibla commented Jan 14, 2020

https://github.com/luniehq/lunie/pull/3338/files#diff-d335fe2836dcf1bee0df07feaa11c188R4
https://github.com/luniehq/lunie/pull/3338/files#diff-d335fe2836dcf1bee0df07feaa11c188R24
https://github.com/luniehq/lunie/pull/3338/files#diff-d335fe2836dcf1bee0df07feaa11c188R39

@faboweb
Copy link
Contributor Author

faboweb commented Jan 14, 2020 •
edited
Loading

Hahhaha thanks for sharing these

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@faboweb @jbibla