typescript definitions not exported by default

[jacobcoro]

when I do import Ledger from '@lunie/cosmos-ledger';
I don't get the types. I have a red squiggly saying no types found.

I opened the node_modules folder and found the types there and when I do import Ledger from '@lunie/cosmos-ledger/lib/cosmos-ledger'; it works.

You might need to change something to get these loaded by default

[faboweb]

Hi Jacob, this library is discontinued. Please use https://github.com/Zondax/ledger-cosmos-js

[jacobcoro]

Hi Jacob, this library is discontinued. Please use https://github.com/Zondax/ledger-cosmos-js

Looks like that library has also not been updated for 2 years

[faboweb]

You could check how Keplr does it: https://github.com/chainapsis/keplr-wallet

[jacobcoro]

You could check how Keplr does it: https://github.com/chainapsis/keplr-wallet

Thanks so much! I could not get it working until I checked Keplr's code as you suggested. This library seemed to handle this step for us, and the new library requires an extra step:

import { signatureImport } from "secp256k1";
    // Parse a DER ECDSA signature
    return signatureImport(result.signature);

source

[jacobcoro]

I think the library devs should make it clear this library is not maintained anymore and point to the new one.
But the new one feels like a bit of a downgrade, being written in js not ts. It's a very small library, it wouldn't be so hard to change to ts, and then it would be a lot easier/nicer to use.
I'm willing to help with that effort if need be.

[faboweb]

You are invited to create a PR with the TS additions. I will flag this library as not maintained.