From d764901ef2bf82b659b0b2d5dea0ea957b80d2f3 Mon Sep 17 00:00:00 2001
From: Fabian <frznhope@gmail.com>
Date: Wed, 18 Dec 2019 14:25:48 -0500
Subject: [PATCH] [Simsala] automatic release created for v1.0.155 (#3335)

* Fabo/handle image null on validator page (#3319)

* handle picture is null

* changelog

* handle null images on page validator

* Update proposals every new block (#3295)

* Update proposals every 10 blocks

* changelog

* istanbul ignore next

* Trigger CI

* istanbul ignore next

* Use loaded

* Update snap

* istanbul ignore next

* Update single proposal page every new block

* Job is done!

* Comment

* Remove comment

* istanbul ignore next

* Improve coverage

* Update all proposal data

* Simplify

* Revert

* Fix watcher func testing

* Fix, cleanup, optimization

* Update snap

* Cleanup

* chooseFilter for pagevalidator. fix website (#3289)

* chooseFilter for pagevalidator. fix website

* changelog

* add filter as second parameter

* add test for isblankfield

* lint

* Ana/3313 add link for linux users to ledger connection issues article (#3315)

* add linux webusb message. center signin button

* add linux test but it errors. lint

* changelog

* fix linux message test

* Ana/fixes-for-pagevalidator (#3323)

* small but important fixes

* changelog

* Fabo/handle async tx failure (#3327)

* add new property to receive notification if tx inclusion failed

* dev life

* changelog

* fix tests

* release-1.0.155
---
 CHANGELOG.md                                  |  13 ++
 package.json                                  |   2 +-
 src/ActionModal/components/SendModal.vue      |   3 +-
 src/ActionModal/utils/ActionManager.js        |   1 +
 src/components/common/TmSessionHardware.vue   |  28 +++
 src/components/governance/PageProposal.vue    |  58 +++++-
 src/components/governance/PageProposals.vue   |  46 ++++-
 src/components/staking/PageValidator.vue      |  32 ++-
 .../ActionModal/utils/ActionManager.spec.js   |   6 +-
 .../common/TmSessionHardware.spec.js          |  19 +-
 .../TmSessionHardware.spec.js.snap            |  36 ++++
 .../governance/PageProposal.spec.js           |   8 +
 .../__snapshots__/PageProposal.spec.js.snap   | 192 +++++++++++++++++-
 .../__snapshots__/PageProposals.spec.js.snap  |  11 +-
 .../components/staking/PageValidator.spec.js  |  17 ++
 .../__snapshots__/PageValidator.spec.js.snap  |  30 +++
 tests/unit/specs/filters/filters.spec.js      |   4 +-
 17 files changed, 466 insertions(+), 40 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7840eba45e..7e413c9100 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,19 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 <!-- SIMSALA --> <!-- DON'T DELETE, used for automatic changelog updates -->
 
+## [1.0.155] - 2019-12-18
+
+### Changed
+
+- [#3313](https://github.com/cosmos/lunie/issues/3313) Now when Linux users go to sign in with Ledger they get a warning message with a link to the Ledger documentation to fix connection issues @Bitcoinera
+- [#3289](https://github.com/cosmos/lunie/pull/3289) Now PageValidator handles empty fields more uniformly, always displaying `--` @Bitcoinera
+
+### Fixed
+
+- [#3323](https://github.com/cosmos/lunie/pull/3323) Fixes the userTransactionAdded subscription and deletes the double TmLoadingComponent @Bitcoinera
+- Show failing txs in action modal @faboweb
+- [#3277](https://github.com/cosmos/lunie/issues/3277) Update proposals every 10 blocks @mariopino
+
 ## [1.0.154] - 2019-12-16
 
 ### Added
diff --git a/package.json b/package.json
index 130adeeb0f..605090a6a3 100644
--- a/package.json
+++ b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "lunie",
-  "version": "1.0.154",
+  "version": "1.0.155",
   "description": "Lunie is the staking and governance platform for proof-of-stake blockchains.",
   "author": "Lunie International Software Systems Inc. <hello@lunie.io>",
   "scripts": {
diff --git a/src/ActionModal/components/SendModal.vue b/src/ActionModal/components/SendModal.vue
index 1568e9f16b..222dc3d091 100644
--- a/src/ActionModal/components/SendModal.vue
+++ b/src/ActionModal/components/SendModal.vue
@@ -132,6 +132,7 @@ import TmFormMsg from "src/components/common/TmFormMsg"
 import ActionModal from "./ActionModal"
 import transaction from "../utils/transactionTypes"
 import { toMicroDenom } from "src/scripts/common"
+import config from "src/../config"
 
 const defaultMemo = "(Sent via Lunie)"
 
@@ -153,7 +154,7 @@ export default {
   },
   data: () => ({
     address: ``,
-    amount: null,
+    amount: config.development ? 0.000001 : null, // dev life, hard life > make simple
     memo: defaultMemo,
     max_memo_characters: 256,
     editMemo: false,
diff --git a/src/ActionModal/utils/ActionManager.js b/src/ActionModal/utils/ActionManager.js
index a8b8c02bc5..b31926890e 100644
--- a/src/ActionModal/utils/ActionManager.js
+++ b/src/ActionModal/utils/ActionManager.js
@@ -193,6 +193,7 @@ export default class ActionManager {
       simulate: false,
       messageType: type,
       networkId: context.networkId,
+      senderAddress: context.userAddress,
       signedMessage
     }
     const result = await this.transactionAPIRequest(txPayload)
diff --git a/src/components/common/TmSessionHardware.vue b/src/components/common/TmSessionHardware.vue
index 3ea2839391..7965ee137f 100644
--- a/src/components/common/TmSessionHardware.vue
+++ b/src/components/common/TmSessionHardware.vue
@@ -34,6 +34,25 @@
               <br />
             </template>
           </template>
+          <template v-else-if="isLinux">
+            Since we switched to WebUSB Linux users may experience connection
+            issues with their devices.
+            <br />
+            <br />
+            Please visit the following site to learn more about how to fix them:
+            <div
+              v-clipboard:copy="linuxLedgerConnectionLink"
+              v-clipboard:success="() => onCopy()"
+              class="copy-feature-link"
+            >
+              {{ linuxLedgerConnectionLink }}
+              <i class="material-icons copied" :class="{ active: copySuccess }">
+                check
+              </i>
+            </div>
+            <br />
+            <br />
+          </template>
           <template v-else-if="status === `connect` || status === `detect`">
             <p>
               Please plug in your Ledger&nbsp;Nano and open the Cosmos Ledger
@@ -82,6 +101,7 @@ export default {
     address: null,
     copySuccess: false,
     hidFeatureLink: `chrome://flags/#enable-experimental-web-platform-features`,
+    linuxLedgerConnectionLink: `https://support.ledger.com/hc/en-us/articles/360019301813-Fix-USB-issues`,
     navigator: window.navigator
   }),
   computed: {
@@ -95,6 +115,9 @@ export default {
     isWindows() {
       return this.navigator.platform.indexOf("Win") > -1
     },
+    isLinux() {
+      return this.navigator.platform.indexOf("Lin") > -1
+    },
     hasHIDEnabled() {
       return !!this.navigator.hid
     },
@@ -199,4 +222,9 @@ export default {
 .copy-feature-link .copied.active {
   opacity: 1;
 }
+
+.session-main .button {
+  margin: 0 auto;
+  display: block;
+}
 </style>
diff --git a/src/components/governance/PageProposal.vue b/src/components/governance/PageProposal.vue
index b586a292fe..5382c048ce 100644
--- a/src/components/governance/PageProposal.vue
+++ b/src/components/governance/PageProposal.vue
@@ -1,12 +1,6 @@
 <template>
   <TmPage data-title="Proposal" hide-header class="small">
-    <TmDataLoading
-      v-if="
-        $apollo.queries.proposals.loading ||
-          $apollo.queries.proposal.loading ||
-          $apollo.queries.parameters.loading
-      "
-    />
+    <TmDataLoading v-if="$apollo.loading && !loaded" />
     <TmDataNotFound v-else-if="!found" />
     <TmDataError v-else-if="error" />
     <template v-else>
@@ -202,6 +196,7 @@ import { ProposalItem, GovernanceParameters, Vote } from "src/gql"
 import BigNumber from "bignumber.js"
 import Bech32 from "common/Bech32"
 import gql from "graphql-tag"
+import refetchNetworkOnly from "scripts/refetch-network-only"
 
 export default {
   name: `page-proposal`,
@@ -243,7 +238,8 @@ export default {
       depositDenom: "TESTCOIN"
     },
     error: undefined,
-    found: false
+    found: false,
+    loaded: false
   }),
   computed: {
     ...mapGetters([`address`, `network`]),
@@ -263,6 +259,12 @@ export default {
       return id
     }
   },
+  watch: {
+    // Needed to show data loading component when you are browsing from one proposal to another
+    $route: function() {
+      this.loaded = false
+    }
+  },
   methods: {
     onVote() {
       this.$refs.modalVote.open()
@@ -319,6 +321,7 @@ export default {
         ) {
           this.found = true
         }
+        /* istanbul ignore next */
         return data.proposals
       }
     },
@@ -328,6 +331,8 @@ export default {
         return ProposalItem(this.network)
       },
       update(data) {
+        /* istanbul ignore next */
+        this.loaded = true
         /* istanbul ignore next */
         return data.proposal
       },
@@ -388,6 +393,43 @@ export default {
         /* istanbul ignore next */
         this.error = data.error
       }
+    },
+    $subscribe: {
+      blockAdded: {
+        variables() {
+          /* istanbul ignore next */
+          return {
+            networkId: this.network
+          }
+        },
+        query() {
+          /* istanbul ignore next */
+          return gql`
+            subscription($networkId: String!) {
+              blockAdded(networkId: $networkId) {
+                height
+              }
+            }
+          `
+        },
+        skip() {
+          /* istanbul ignore next */
+          return !this.found
+        },
+        result() {
+          /* istanbul ignore next */
+          if (
+            // Don't update passed or rejected proposals
+            this.proposal.status !== "Passed" &&
+            this.proposal.status !== "Rejected" &&
+            this.loaded
+          ) {
+            refetchNetworkOnly(this.$apollo.queries.proposal)
+            refetchNetworkOnly(this.$apollo.queries.parameters)
+            refetchNetworkOnly(this.$apollo.queries.vote)
+          }
+        }
+      }
     }
   }
 }
diff --git a/src/components/governance/PageProposals.vue b/src/components/governance/PageProposals.vue
index e25dfe7977..867c9726f2 100644
--- a/src/components/governance/PageProposals.vue
+++ b/src/components/governance/PageProposals.vue
@@ -1,5 +1,10 @@
 <template>
-  <TmPage data-title="Proposals" :managed="false" hide-header>
+  <TmPage
+    data-title="Proposals"
+    :managed="true"
+    hide-header
+    :loading="$apollo.loading && !loaded"
+  >
     <div class="button-container">
       <TmBtn
         id="propose-btn"
@@ -26,10 +31,7 @@
         </TmDataMsg>
       </div>
     </div>
-    <div v-else>
-      <TmDataLoading v-if="$apollo.loading" />
-      <TableProposals v-else :proposals="proposals" />
-    </div>
+    <TableProposals v-else :proposals="proposals" />
   </TmPage>
 </template>
 
@@ -39,10 +41,10 @@ import TableProposals from "governance/TableProposals"
 import TmPage from "common/TmPage"
 import TmBtn from "common/TmBtn"
 import TmDataMsg from "common/TmDataMsg"
-import TmDataLoading from "common/TmDataLoading"
 import { mapGetters } from "vuex"
 import { GovernanceParameters } from "src/gql"
 import gql from "graphql-tag"
+import refetchNetworkOnly from "scripts/refetch-network-only"
 
 export default {
   name: `page-proposals`,
@@ -50,7 +52,6 @@ export default {
     ModalPropose,
     TableProposals,
     TmDataMsg,
-    TmDataLoading,
     TmBtn,
     TmPage
   },
@@ -58,7 +59,8 @@ export default {
     proposals: [],
     parameters: {
       depositDenom: "xxx"
-    }
+    },
+    loaded: false
   }),
   computed: {
     ...mapGetters([`network`])
@@ -89,11 +91,14 @@ export default {
         `
       },
       variables() {
+        /* istanbul ignore next */
         return {
           networkId: this.network
         }
       },
       update(data) {
+        /* istanbul ignore next */
+        this.loaded = true
         /* istanbul ignore next */
         return data.proposals
       }
@@ -107,10 +112,35 @@ export default {
         /* istanbul ignore next */
         return data.governanceParameters
       }
+    },
+    $subscribe: {
+      blockAdded: {
+        variables() {
+          /* istanbul ignore next */
+          return {
+            networkId: this.network
+          }
+        },
+        query() {
+          /* istanbul ignore next */
+          return gql`
+            subscription($networkId: String!) {
+              blockAdded(networkId: $networkId) {
+                height
+              }
+            }
+          `
+        },
+        result() {
+          /* istanbul ignore next */
+          refetchNetworkOnly(this.$apollo.queries.proposals)
+        }
+      }
     }
   }
 }
 </script>
+
 <style scoped>
 .button-container {
   display: flex;
diff --git a/src/components/staking/PageValidator.vue b/src/components/staking/PageValidator.vue
index d2704989c6..5a9aac574e 100644
--- a/src/components/staking/PageValidator.vue
+++ b/src/components/staking/PageValidator.vue
@@ -8,8 +8,7 @@
     data-title="Validator"
     class="small"
   >
-    <TmDataLoading v-if="$apollo.queries.validator.loading" />
-    <template v-else-if="validator.operatorAddress" slot="managed-body">
+    <template v-if="validator.operatorAddress" slot="managed-body">
       <div class="status-container">
         <span :class="validator.status | toLower" class="validator-status">
           {{ validator.status }}
@@ -66,7 +65,7 @@
         </li>
         <li class="column">
           <h4>Website</h4>
-          <span v-if="validator.website !== ``">
+          <span v-if="validator.website">
             <a
               id="validator-website"
               :href="validator.website + `?ref=lunie`"
@@ -114,25 +113,29 @@
         </li>
         <li>
           <h4>Uptime</h4>
-          <span id="page-profile__uptime">
-            {{ validator.uptimePercentage | percent }}
-          </span>
+          <span id="page-profile__uptime">{{
+            isBlankField(validator.uptimePercentage, percent)
+          }}</span>
         </li>
         <li>
           <h4>Current Commission Rate</h4>
-          <span>{{ validator.commission | percent }}</span>
+          <span>{{ isBlankField(validator.commission, percent) }}</span>
         </li>
         <li>
           <h4>Max Commission Rate</h4>
-          <span>{{ validator.maxCommission | percent }}</span>
+          <span>{{ isBlankField(validator.maxCommission, percent) }}</span>
         </li>
         <li>
           <h4>Max Daily Commission Change</h4>
-          <span>{{ validator.maxChangeCommission | percent }}</span>
+          <span>{{
+            isBlankField(validator.maxChangeCommission, percent)
+          }}</span>
         </li>
         <li>
           <h4>Last Commission Change</h4>
-          <span>{{ validator.commissionUpdateTime | fromNow }}</span>
+          <span>{{
+            isBlankField(validator.commissionUpdateTime, fromNow)
+          }}</span>
         </li>
       </ul>
 
@@ -230,6 +233,8 @@ export default {
     shortDecimals,
     atoms,
     percent,
+    fromNow,
+    noBlanks,
     moment,
     onDelegation(options) {
       this.$refs.delegationModal.open(options)
@@ -251,6 +256,9 @@ export default {
         `undelegations`,
         `transactions`
       ]) // TODO use more finegrained query string (network and address)
+    },
+    isBlankField(field, alternateFilter) {
+      return field ? alternateFilter(field) : noBlanks(field)
     }
   },
   apollo: {
@@ -364,6 +372,10 @@ export default {
             address: this.userAddress
           }
         },
+        skip() {
+          /* istanbul ignore next */
+          return !this.userAddress
+        },
         query: UserTransactionAdded,
         result({ data }) {
           /* istanbul ignore next */
diff --git a/tests/unit/specs/components/ActionModal/utils/ActionManager.spec.js b/tests/unit/specs/components/ActionModal/utils/ActionManager.spec.js
index 5421a87c0d..cf83626fcf 100644
--- a/tests/unit/specs/components/ActionModal/utils/ActionManager.spec.js
+++ b/tests/unit/specs/components/ActionModal/utils/ActionManager.spec.js
@@ -308,7 +308,8 @@ describe("ActionManager", () => {
         simulate: false,
         messageType: "MsgSend",
         networkId: "cosmos-hub-testnet",
-        signedMessage: "signedMessage"
+        signedMessage: "signedMessage",
+        senderAddress: "cosmos12345"
       }
 
       expect(actionManager.transactionAPIRequest).toHaveBeenCalledWith(
@@ -341,7 +342,8 @@ describe("ActionManager", () => {
         simulate: false,
         messageType: "MsgWithdrawDelegationReward",
         networkId: "cosmos-hub-testnet",
-        signedMessage: "signedMessage"
+        signedMessage: "signedMessage",
+        senderAddress: "cosmos12345"
       }
 
       expect(actionManager.transactionAPIRequest).toHaveBeenCalledWith(
diff --git a/tests/unit/specs/components/common/TmSessionHardware.spec.js b/tests/unit/specs/components/common/TmSessionHardware.spec.js
index 5072fc3360..02441bd274 100644
--- a/tests/unit/specs/components/common/TmSessionHardware.spec.js
+++ b/tests/unit/specs/components/common/TmSessionHardware.spec.js
@@ -6,8 +6,9 @@ import TmSessionHardware from "common/TmSessionHardware"
 const localVue = createLocalVue()
 localVue.use(Vuex)
 localVue.use(Vuelidate)
-localVue.directive(`tooltip`, () => { })
-localVue.directive(`focus`, () => { })
+localVue.directive(`tooltip`, () => {})
+localVue.directive(`focus`, () => {})
+localVue.directive('clipboard', () => {})
 
 describe(`TmSessionHardware`, () => {
   let wrapper, store
@@ -117,6 +118,20 @@ describe(`TmSessionHardware`, () => {
       )
     })
 
+    it(`does show the instructions to fix connection issues for Linux users`, () => {
+      wrapper.setData({
+        navigator: {
+          platform: "Linux i686",
+          userAgent: "Chrome"
+        }
+      })
+
+      expect(wrapper.html()).toMatchSnapshot()
+      expect(wrapper.html()).toContain(
+        "Since we switched to WebUSB Linux users may experience connection"
+      )
+    })
+
     describe(`onCopy`, () => {
       it(`should set and reset copySuccess`, () => {
         jest.useFakeTimers()
diff --git a/tests/unit/specs/components/common/__snapshots__/TmSessionHardware.spec.js.snap b/tests/unit/specs/components/common/__snapshots__/TmSessionHardware.spec.js.snap
index 2423adeac2..2985d026c8 100644
--- a/tests/unit/specs/components/common/__snapshots__/TmSessionHardware.spec.js.snap
+++ b/tests/unit/specs/components/common/__snapshots__/TmSessionHardware.spec.js.snap
@@ -337,3 +337,39 @@ exports[`TmSessionHardware sign in does show the instructions to enable HID on W
     </button> <a class="user-box"><i class="material-icons">close</i></a></div>
 </div>
 `;
+
+exports[`TmSessionHardware sign in does show the instructions to fix connection issues for Linux users 1`] = `
+<div class="session-frame" name="component-fade" mode="out-in">
+  <router-link-stub to="/"><img src="~assets/images/lunie-logo-white.svg" class="session-logo"></router-link-stub>
+  <div class="session-outer-container">
+    <div class="session"><a><i class="material-icons circle back">arrow_back</i></a>
+      <h2 class="session-title">
+        Use my Ledger Nano
+      </h2>
+      <div class="session-main">
+        <div class="tm-hardware-state">
+          <div class="tm-hardware-state-content">
+            <!---->
+            <div class="tm-hardware-state__label">
+              Since we switched to WebUSB Linux users may experience connection
+              issues with their devices.
+              <br> <br>
+              Please visit the following site to learn more about how to fix them:
+              <div class="copy-feature-link">
+                https://support.ledger.com/hc/en-us/articles/360019301813-Fix-USB-issues
+                <i class="material-icons copied">
+                  check
+                </i></div> <br> <br>
+              <!----> <button class="button">
+                Sign In
+              </button></div> <img src="~assets/images/loader.svg" alt="a small spinning circle to display loading" style="display: none;">
+          </div>
+        </div>
+      </div>
+    </div>
+  </div>
+  <div class="session-close"><button class="button session-close-button" color="secondary">
+      Back to Lunie
+    </button> <a class="user-box"><i class="material-icons">close</i></a></div>
+</div>
+`;
diff --git a/tests/unit/specs/components/governance/PageProposal.spec.js b/tests/unit/specs/components/governance/PageProposal.spec.js
index 52b19288d4..c10a7c2c55 100644
--- a/tests/unit/specs/components/governance/PageProposal.spec.js
+++ b/tests/unit/specs/components/governance/PageProposal.spec.js
@@ -34,6 +34,7 @@ describe(`PageProposal`, () => {
       getters,
       state
     }
+
     const $apollo = {
       queries: {
         proposals: {
@@ -119,6 +120,13 @@ describe(`PageProposal`, () => {
     expect(wrapper.vm.getProposalIndex(1)).toEqual(32)
   })
 
+  it(`should set loaded to false on route change`, () => {
+    wrapper.vm.loaded = true
+    // Call directly watcher function
+    wrapper.vm.$options.watch.$route.call(wrapper.vm, { path: "xxxx" })
+    expect(wrapper.vm.loaded).toBe(false)
+  })
+
   describe(`Proposal status`, () => {
     it(`displays correctly a proposal that 'Passed'`, () => {
       wrapper.vm.proposal.status = `Passed`
diff --git a/tests/unit/specs/components/governance/__snapshots__/PageProposal.spec.js.snap b/tests/unit/specs/components/governance/__snapshots__/PageProposal.spec.js.snap
index fca349571b..1d8596bc68 100644
--- a/tests/unit/specs/components/governance/__snapshots__/PageProposal.spec.js.snap
+++ b/tests/unit/specs/components/governance/__snapshots__/PageProposal.spec.js.snap
@@ -159,8 +159,196 @@ exports[`PageProposal should show a loader if the necessary data hasen't been lo
   subtitle=""
   title=""
 >
-  <tmdataloading-stub
-    title="Data is loading…"
+  <div
+    class="proposal"
+  >
+    <div
+      class="page-profile__header__info"
+    >
+      <span
+        class="proposal-status rejected"
+      >
+        
+          Rejected
+        
+      </span>
+       
+      <div
+        class="proposal-title__row"
+      >
+        <router-link-stub
+          class="read-more-link"
+          style="visibility: hidden;"
+          to="/proposals/undefined"
+        >
+          <i
+            class="material-icons"
+          >
+            chevron_left
+          </i>
+        </router-link-stub>
+         
+        <h2
+          class="proposal-title"
+        >
+          test
+        </h2>
+         
+        <router-link-stub
+          class="read-more-link"
+          style="visibility: hidden;"
+          to="/proposals/undefined"
+        >
+          <i
+            class="material-icons"
+          >
+            chevron_right
+          </i>
+        </router-link-stub>
+      </div>
+       
+      <p
+        class="proposer"
+      >
+        
+            Proposed by Big Daddy Validator:
+            
+        <bech32-stub
+          address="cosmos1z8mzakma7vnaajysmtkwt4wgjqr2m84tzvyfkz"
+        />
+      </p>
+    </div>
+     
+    <div
+      class="button-container"
+    >
+      <tmbtn-stub
+        color="primary"
+        disabled="true"
+        id="deposit-btn"
+        value="Deposit"
+      />
+       
+      <tmbtn-stub
+        color="primary"
+        disabled="true"
+        id="vote-btn"
+        value="Vote"
+      />
+    </div>
+  </div>
+   
+  <textblock-stub
+    content="test"
+  />
+   
+  <!---->
+   
+  <ul
+    class="row"
+  >
+    <!---->
+     
+    <li>
+      <h4>
+        Yes
+      </h4>
+       
+      <span>
+        
+          0.00%
+          /
+          0
+        
+      </span>
+    </li>
+     
+    <li>
+      <h4>
+        No
+      </h4>
+       
+      <span>
+        
+          0.00%
+          /
+          0
+        
+      </span>
+    </li>
+     
+    <li>
+      <h4>
+        Veto
+      </h4>
+       
+      <span>
+        
+          0.00%
+          /
+          0
+        
+      </span>
+    </li>
+     
+    <li>
+      <h4>
+        Abstain
+      </h4>
+       
+      <span>
+        
+          0.00%
+          /
+          0
+        
+      </span>
+    </li>
+  </ul>
+   
+  <ul
+    class="row"
+  >
+    <li>
+      <h4>
+        Proposal ID
+      </h4>
+       
+      <span>
+        33
+      </span>
+    </li>
+     
+    <li>
+      <h4>
+        Submitted
+      </h4>
+       
+      <span>
+        August 23rd 2019, 08:46
+      </span>
+    </li>
+     
+    <li>
+      <h4>
+        Proposal Finalized (Rejected)
+      </h4>
+       
+      <span>
+        August 25th 2019, 08:46
+      </span>
+    </li>
+  </ul>
+   
+  <modaldeposit-stub
+    denom="TESTCOIN"
+    proposalid="33"
+    proposaltitle="test"
+  />
+   
+  <modalvote-stub
+    proposalid="33"
+    proposaltitle="test"
   />
 </tmpage-stub>
 `;
diff --git a/tests/unit/specs/components/governance/__snapshots__/PageProposals.spec.js.snap b/tests/unit/specs/components/governance/__snapshots__/PageProposals.spec.js.snap
index edbaf8b20d..da85fc9fc5 100644
--- a/tests/unit/specs/components/governance/__snapshots__/PageProposals.spec.js.snap
+++ b/tests/unit/specs/components/governance/__snapshots__/PageProposals.spec.js.snap
@@ -4,6 +4,7 @@ exports[`PageProposals shows a message if still loading 1`] = `
 <tmpage-stub
   data-title="Proposals"
   hideheader="true"
+  managed="true"
   subtitle=""
   title=""
 >
@@ -48,6 +49,7 @@ exports[`PageProposals shows a message if there is nothing to display 1`] = `
 <tmpage-stub
   data-title="Proposals"
   hideheader="true"
+  managed="true"
   subtitle=""
   title=""
 >
@@ -92,6 +94,7 @@ exports[`PageProposals shows a proposals table 1`] = `
 <tmpage-stub
   data-title="Proposals"
   hideheader="true"
+  managed="true"
   subtitle=""
   title=""
 >
@@ -109,10 +112,8 @@ exports[`PageProposals shows a proposals table 1`] = `
     denom="lunies"
   />
    
-  <div>
-    <tableproposals-stub
-      proposals="[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object]"
-    />
-  </div>
+  <tableproposals-stub
+    proposals="[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object],[object Object]"
+  />
 </tmpage-stub>
 `;
diff --git a/tests/unit/specs/components/staking/PageValidator.spec.js b/tests/unit/specs/components/staking/PageValidator.spec.js
index 3ced5ce70e..f61886bd94 100644
--- a/tests/unit/specs/components/staking/PageValidator.spec.js
+++ b/tests/unit/specs/components/staking/PageValidator.spec.js
@@ -97,4 +97,21 @@ describe(`PageValidator`, () => {
     $store.state.session.signedIn = false
     expect(wrapper.element).toMatchSnapshot()
   })
+  it(`if uptimePercentage is blank`, () => {
+    wrapper.setProps({ validator: { uptimePercentage: `` } })
+    expect(wrapper.element).toMatchSnapshot()
+  })
+})
+
+describe(`isBlankField method`, () => {
+  it(`returns "--"`, async () => {
+    validator.maxCommission = null
+    const percent = jest.fn()
+    const afterFilter = PageValidator.methods.isBlankField(
+      validator.maxCommission,
+      percent
+    )
+
+    expect(afterFilter).toBe(`--`)
+  })
 })
diff --git a/tests/unit/specs/components/staking/__snapshots__/PageValidator.spec.js.snap b/tests/unit/specs/components/staking/__snapshots__/PageValidator.spec.js.snap
index cfcf614b15..1783fc195e 100644
--- a/tests/unit/specs/components/staking/__snapshots__/PageValidator.spec.js.snap
+++ b/tests/unit/specs/components/staking/__snapshots__/PageValidator.spec.js.snap
@@ -1,5 +1,35 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`PageValidator if uptimePercentage is blank 1`] = `
+<tmpage-stub
+  class="small"
+  data-title="Validator"
+  dataempty="true"
+  hideheader="true"
+  managed="true"
+  subtitle=""
+  title=""
+>
+  <div>
+    Validator Not Found
+  </div>
+   
+  <div>
+    
+      Please visit the
+      
+    <router-link-stub
+      to="/validators/"
+    >
+       Validators 
+    </router-link-stub>
+    page to view
+      all validators
+    
+  </div>
+</tmpage-stub>
+`;
+
 exports[`PageValidator if user has signed in - status text banned 1`] = `
 <tmpage-stub
   class="small"
diff --git a/tests/unit/specs/filters/filters.spec.js b/tests/unit/specs/filters/filters.spec.js
index e7c6ee1d55..2ebe69ed2d 100644
--- a/tests/unit/specs/filters/filters.spec.js
+++ b/tests/unit/specs/filters/filters.spec.js
@@ -28,7 +28,9 @@ describe(`formatBech32 Filter`, () => {
   })
 
   it(`should return an abbreviated version of an Ethereum address, with "0x" and then the first four characters, followed by "..." and finally the last four characters`, () => {
-    expect(formatBech32(`0x00b1606fc5b771f3079b4fd3ea49e66a2d5fd665`)).toBe(`0x00b1…d665`)
+    expect(formatBech32(`0x00b1606fc5b771f3079b4fd3ea49e66a2d5fd665`)).toBe(
+      `0x00b1…d665`
+    )
   })
 
   it(`should return 'Not A Valid Bech32 Address' when no 1 is present`, () => {