Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TmPage "managed-body" refactor #2237

Closed
faboweb opened this issue Mar 11, 2019 · 1 comment · Fixed by #2300
Closed

TmPage "managed-body" refactor #2237

faboweb opened this issue Mar 11, 2019 · 1 comment · Fixed by #2300
Labels
refactor

Comments

@faboweb
Copy link
Collaborator

faboweb commented Mar 11, 2019

The usage of a check on the slot property this.$slots['managed-body'] smells dirty. Is this really needed?

No proposal yet. Need to discuss. @sabau
@jbibla jbibla mentioned this issue Mar 12, 2019
Merged
5 tasks
@faboweb
Copy link
Collaborator Author

faboweb commented Mar 18, 2019

Did a slight refactor in #2300

@jbibla jbibla mentioned this issue Mar 18, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jordan/2267+2278 validator table bugs luniehq/lunie
1 participant
@faboweb