Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on Active on Validators page select both All and Active tabs #3280

Closed
iambeone opened this issue Dec 10, 2019 · 4 comments · Fixed by #3397
Closed

Clicking on Active on Validators page select both All and Active tabs #3280

iambeone opened this issue Dec 10, 2019 · 4 comments · Fixed by #3397
Assignees
@mariopino
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@iambeone
Copy link
Contributor

iambeone commented Dec 10, 2019 •
edited
Loading

Clicking on Active on Validators page select both All and Active tabs
ezgif-1-348c75e76012
@jbibla
Copy link
Collaborator

jbibla commented Dec 10, 2019

is this a css bug?

@iambeone
Copy link
Contributor Author

Should be

@jbibla jbibla added the bug 🐛 issues related to unhandled errors in the code that need to be fixed label Dec 10, 2019
@mariopino
Copy link
Contributor

@iambeone I can't replicate it, what browser are you using?

@jbibla
Copy link
Collaborator

jbibla commented Dec 14, 2019

ah ok. this can be replicated by clicking on the tab that's already selected. it toggles the selected tab and then you are left "hovering" over the one that is now deselected, while the other is selected.

the fix is just to make sure that when you click one side it only activates the side that was clicked. right now both are toggles for each other.

@mariopino mariopino self-assigned this Jan 10, 2020
@mariopino mariopino mentioned this issue Jan 10, 2020
Merged
5 tasks
This was referenced Jan 10, 2020
Merged
Closed
This was referenced Jan 18, 2020
Merged
Merged
This was referenced Jan 25, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariopino mariopino

Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace toggles in all and active buttons in validators page luniehq/lunie
3 participants
@jbibla @mariopino @iambeone