-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ana/multiple denoms in porfolio (missing better designs) #3365
Merged
Merged
Changes from 14 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ba70382
add balance of various tokens
Bitcoinera 81e6c7e
update snapshot
Bitcoinera 3d31015
fix word misordering
Bitcoinera 3866659
try fix asynchrony
Bitcoinera 6e7c8ba
add currency selector
Bitcoinera 3682bf4
fix select currency. hack for placeholder
Bitcoinera 337b69c
important fixes
Bitcoinera 802012a
update snapshot
Bitcoinera 0c25e23
changelog
Bitcoinera f3b3102
getting things ready
Bitcoinera 66d8554
fixes but totalfiatvalue query not triggered
Bitcoinera 14b8681
all working
Bitcoinera 4f20515
update snapshot
Bitcoinera 2eded47
add test for new computed fields
Bitcoinera 22564e1
adapt logic to recent changes
Bitcoinera a03eb2f
merge develop
Bitcoinera 9c6aee6
add getalldenoms test
Bitcoinera e8be4eb
travel to istanbul
Bitcoinera aeff1d0
delete usertransactionadded
Bitcoinera 33ccad9
add watch test
Bitcoinera 2ff9be8
set eur as default selected fiat currency
Bitcoinera File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
[Added] [#3365](https://github.com/cosmos/lunie/pull/3365) TmBalance now displays multiple tokens balances and has a currency selector to display total value in the selected fiat currency @Bitcoinera |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this produces a roundtrip. why not include this somehow in the overview. it will always be served together right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't you say in the other PR you wanted to slice overview in separate queries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true, but the idea was to serve fiat values directly with any amount. We will want to show always the fiat value together with the token amount. So this simplifies things in the FE.