Skip to content

Commit

Permalink
[FastISel][AArch64] Fold offset into the memory operation.
Browse files Browse the repository at this point in the history
Fold simple offsets into the memory operation:
  add x0, x0, brson#8
  ldr x0, [x0]
-->
  ldr x0, [x0, brson#8]

Fixes <rdar://problem/17887945>.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@214545 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
ributzka committed Aug 1, 2014
1 parent 7485669 commit 8d3bf10
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 0 deletions.
7 changes: 7 additions & 0 deletions lib/Target/AArch64/AArch64FastISel.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,13 @@ bool AArch64FastISel::ComputeAddress(const Value *Obj, Address &Addr) {
}
break;
}
case Instruction::Add:
// Adds of constants are common and easy enough.
if (const ConstantInt *CI = dyn_cast<ConstantInt>(U->getOperand(1))) {
Addr.setOffset(Addr.getOffset() + (uint64_t)CI->getSExtValue());
return ComputeAddress(U->getOperand(0), Addr);
}
break;
}

// Try to get this in a register if nothing else has worked.
Expand Down
23 changes: 23 additions & 0 deletions test/CodeGen/AArch64/fast-isel-compute-address.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
; RUN: llc -fast-isel -fast-isel-abort -mtriple=arm64-apple-darwin < %s | FileCheck %s

; Test simple constant offset.
define i64 @test_load1(i64 %a) {
; CHECK-LABEL: test_load1
; CHECK: ldr x0, [x0, #16]
%1 = add i64 %a, 16
%2 = inttoptr i64 %1 to i64*
%3 = load i64* %2
ret i64 %3
}

; Test large constant offset.
define i64 @test_load2(i64 %a) {
; CHECK-LABEL: test_load2
; CHECK: add [[REG:x[0-9]+]], x0, {{x[0-9]+}}
; CHECK: ldr x0, {{\[}}[[REG]]{{\]}}
%1 = add i64 %a, 16777216
%2 = inttoptr i64 %1 to i64*
%3 = load i64* %2
ret i64 %3
}

0 comments on commit 8d3bf10

Please sign in to comment.