Emulated and ed25519 crates #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmorais
reviewed
Sep 14, 2023
emmorais
reviewed
Sep 14, 2023
emmorais
reviewed
Sep 14, 2023
emmorais
reviewed
Sep 14, 2023
emmorais
reviewed
Sep 14, 2023
|
I am fixing the |
avras
force-pushed
the
ed25519-gadget
branch
from
73e302a to
f96a0bf
Compare
emmorais
approved these changes
Sep 19, 2023
huitseeker
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Thank you so much for the excellent contribution @avras and @varunthakore!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding two crates
bellpepper-emulatedis a crate for implementing non-native arithmetic. It is inspired by the inspired by the emulated package in Gnark. It has been tested via an implementation ofed25519curve operations. Further testing through implementation of other curves likesecp256k1is a TODO.bellpepper-ed25519is a crate for implementing ed25519 curve operations. It does NOT support ed25519 signature verification as of now. Only point addition and scalar multiplication are implemented.