Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Exported histogram bin size set incorrectly #302

Closed
dorisjlee opened this issue Mar 12, 2021 · 0 comments · Fixed by #304
Closed

[BUG] Exported histogram bin size set incorrectly #302

dorisjlee opened this issue Mar 12, 2021 · 0 comments · Fixed by #304
Assignees
@micahtyong
Labels
bug Something isn't working priority high priority tasks (for dev)

Comments

@dorisjlee
Copy link
Member

Describe the bug
The mark bar size in the exported code is incorrect, leading to very skinny bars. We need to input the adaptive bar sizes determined in #217 inside .mark_bar(size=...).

To Reproduce

df = pd.read_csv("https://raw.githubusercontent.com/lux-org/lux-datasets/master/data/employee.csv")
series = df["YearsAtCompany"]/df["TotalWorkingYears"]
series

Then click on export for the resulting visualization

print(series.exported[0].to_code("altair"))

The code that is generated looks like this
image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@micahtyong micahtyong

Labels
bug Something isn't working priority high priority tasks (for dev)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Altair] Sync exported histogram code with new bin determination micahtyong/lux
2 participants
@dorisjlee @micahtyong