Allow to share the CA between servers #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -372,6 +377,7 @@ | |||
| $persist_tun = false, | |||
| $server_poll_timeout = undef, | |||
| $ping_timer_rem = false, | |||
| $shared_ca = undef | |||
There was a problem hiding this comment.
Please add a trailing comma so we have less changes next time.
|
Thanks a lot for your pull request! I am very sorry for my late reply, I was too busy... Could you write some tests for the client and the server? Could you also merge master as there have been some changes? |
sileht
force-pushed
the
sileht/shared_ca
branch
from
580d5c0
to
e8501e5
Compare
|
I have rebase my patch, and added some tests. Cheers, |
|
Thanks for rebasing. Unfortunately there have been some more changes which produce merge conflicts. I am going to resolve them by myself via #130 as I don't want you to have to rebase again 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This change allows to share the CA between servers.
Regards.