Add TLS and x509-name verification support #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maetthu-indermuehle
commented
Jan 8, 2015
maetthu-indermuehle
commented
- Server config
- Added tls-server and tls-auth parameters to server config template
- Generate TLS key on server while setting up the CA
- Client config
- Link tls key into client config bundle
- Added x509-name parameter to client config template
- Added test for tls and x509-name support in client and server
- Server config - Added tls-server and tls-auth parameters to server config template - Generate TLS key on server while setting up the CA - Client config - Link tls key into client config bundle - Added x509-name parameter to client config template - Added test for tls and x509-name support in client and server
- changed typo in client template - changed typo in documenation of client.pp
- Removed trailing whitespaces in documenation of server.pp
| @@ -99,6 +103,7 @@ | |||
| $key_cn = '', | |||
| $key_name = '', | |||
| $key_ou = '', | |||
| $tls_auth = 'false', | |||
There was a problem hiding this comment.
Please use a boolean instead of a string here.
|
Thanks a lot for this contribution! I added some comments directly in the code. |
- Fixed some minor style stuff - Added revese test - Changed some dependencies
|
Thanks for the Input. I changed the points you mentioned. Except for the ordering. I don't have any good solution there without coping unnecessary code. Do you have any good ideas? |
|
🔝 |
|
You are right.... Could you merge master once more as there are merge conflicts? Afterwards we are ready to merge. |
Conflicts: manifests/client.pp spec/defines/openvpn_client_spec.rb
|
I did a merge to the master. |
|
Thanks, could you fix the tests? |
- Fixed problem with tls-server parameter in upd setups
|
I fixed the test. One parameter was set twice. |
|
Thanks! |
luxflux
added a commit
that referenced
this pull request
Feb 2, 2015
Add TLS and x509-name verification support
|
Thanks for merging! =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.