Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only warn about pam if it's used #72

Merged
merged 1 commit into from
May 19, 2014
Merged

Only warn about pam if it's used #72

merged 1 commit into from
May 19, 2014

Conversation

BillWeiss
Copy link
Contributor

On upgrading to the most recent master here, I got complaints like this:

Warning: Scope(Openvpn::Client[user1@vpn.clanspum.net]): Using $pam is deprecated. Use $authuserpass instead!
Warning: Scope(Openvpn::Client[user2@vpn.clanspum.net]): Using $pam is deprecated. Use $authuserpass instead!
Warning: Scope(Openvpn::Client[user3@vpn.clanspum.net]): Using $pam is deprecated. Use $authuserpass instead!
Warning: Scope(Openvpn::Client[user4@vpn.clanspum.net]): Using $pam is deprecated. Use $authuserpass instead!

I never used $pam, so I was surprised. I added a little logic around it to only warn if $pam is set to something.

@luxflux
Copy link
Contributor

luxflux commented May 19, 2014

Thank you! I missed this one....

luxflux added a commit that referenced this pull request May 19, 2014
@luxflux
Merge pull request #72 from BillWeiss/fix-pam-deprecation-warning
a234f5c 
Only warn about pam if it's used
@luxflux luxflux merged commit a234f5c into voxpupuli:master May 19, 2014
luxflux added a commit that referenced this pull request May 19, 2014
@luxflux
Add #71 and #72 to changelog [ci skip]
c94ffe6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BillWeiss @luxflux