-
-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of default value for for properties using the Key Expansion mechanism #84
Conversation
We try to find the unexpanded key in propertiesManager to locate default value when the expandedKey is not found.
We want to obtain default value if anything goes wrong in locating expanded key in our source.
Thanks. I'll look into it asap. Luigi. |
The unit test looks correct, so the use case you spotted should work as you expect. But I'll try to get a more linear implementation, based on your commit, before merging. Thanks. |
Hi @andreipet, I've checked your code, but I need some more time to check the consistency of other features. Give me some more time, in this period I'm busy with work and personal life. Thank you again for your contribution. L. |
Sure man. Take your time. Thank you for your reply.
|
By the way. When you will have time, we could talk about performance. ☺
|
I invite you to open an improvement request and explain the code spot where you found the performance bottlenecks. What I learned about performance tuning is: first you profile, then you optimize: http://c2.com/cgi/wiki?ProfileBeforeOptimizing Understanding performance hot spot just by looking at the code, is 99% of the times deceiving. |
Use of default value for for properties using the Key Expansion mechanism. To be revised.
We have to get default values even for properties using the Key Expansion mechanism.
I see 2 alternatives:
I had chosen the first solution.