Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List project contributors in the app #296

Closed
lwouis opened this issue May 5, 2020 · 1 comment
Closed

List project contributors in the app #296

lwouis opened this issue May 5, 2020 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@lwouis
Copy link
Owner

lwouis commented May 5, 2020

After #245 we display credits for third-party libraries. We don't display any credits for contributors to the actual project.

I would like to add the list of contributors from github and from poeditor. I could be just a list of nicknames. It could be sorted by category, or list commits. It could link or not to the author github account or email. A lot is possible here in terms of UI.

@lwouis lwouis added documentation Improvements or additions to documentation enhancement New feature or request labels May 5, 2020
@lwouis lwouis changed the title Add contributors list in some in-app UI List project contributors in the app May 5, 2020
@lwouis
Copy link
Owner Author

lwouis commented May 9, 2020

I have added a bash script which lists contributors in docs/CONTRIBUTORS.md.

I have only kept usernames, in order to preserve privacy (i.e. no emails). For github contributors, I have linked to their github profile as this is public information and promotes them.

I added a check in CI so that the markdown file is always up-to-date without needing to remember to run it. The check also ensures other files are up-to-date: localization reference file, localizations files in each language, and cocoapods libraries.

I'm keeping this ticket open because I would like to add that info in-app, probably merging it with the existing Acknowledgments preference tab.

lwouis added a commit that referenced this issue Jul 10, 2020
Also better present the third-party libraries, with links and less noise from the licenses text
lwouis added a commit that referenced this issue Jul 10, 2020
Also better present the third-party libraries, with links and less noise from the licenses text
lwouis added a commit that referenced this issue Jul 10, 2020
Also better present the third-party libraries, with links and less noise from the licenses text
lwouis added a commit that referenced this issue Jul 10, 2020
Also better present the third-party libraries, with links and less noise from the licenses text
lwouis added a commit that referenced this issue Jul 10, 2020
Also better present the third-party libraries, with links and less noise from the licenses text
@lwouis lwouis closed this as completed in 126eca5 Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant