Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails should be vertically centered #343

Closed
alinalihassan opened this issue May 19, 2020 · 5 comments
Closed

Thumbnails should be vertically centered #343

alinalihassan opened this issue May 19, 2020 · 5 comments
Labels
preference Introduction of a new preference

Comments

@alinalihassan
Copy link

Describe the bug

Upon pressing Option+Tab, the windows do not appear to be centered vertically.

Screenshots / video

AltTab

Steps to reproduce the bug

  1. Install the latest version of AltTab
  2. Press Option+Tab and see for yourself
@alinalihassan alinalihassan added the bug Something isn't working label May 19, 2020
@lwouis
Copy link
Owner

lwouis commented May 20, 2020

Hi @hassanalinali! Thanks for taking the time to share this feedback!

The vertical alignment is intentionally top-aligned instead of center-aligned. This is the first time someone seem to have an issue with top-aligned. I was intrigued, and checked other apps:

  • HyperSwitch: bottom-aligned
  • WindowsSwitcher: center-aligned
  • Windows 10 alt-tab: top-aligned

I started this project as a clone of Windows 10 alt-tab, which I love. That's why the thumbnails are top-aligned today. As often with UX choices, my thinking was that Microsoft has done UX research and user studies to decide these things, and copying what they picked is the safe option when in doubt.

Could you please help us and elaborate what the benefits of center-aligned over top-aligned would be?

Right now it seems to me like it could be yet another preference. I don't know how to handle the growing number of preferences though. The preferences panel UX is becoming bad for casual users.

@lwouis lwouis added enhancement New feature or request preference Introduction of a new preference and removed bug Something isn't working labels May 20, 2020
@lwouis lwouis changed the title AltTab vertical alignment not centered Thumbnails should be vertically centered May 20, 2020
@alinalihassan
Copy link
Author

Hey @lwouis, I understand now what you mean. I honestly thought for a second that it is a bug since the built-in Application Switcher and HyperSwitch (from which I just switched to AltTab) are both centered vertically. If it is on purpose and there's no plan to offer an option in the preferences, then I assume we can close this issue. I could also consider making a PR with this enhancement if you would consider it appropriate.

@alinalihassan
Copy link
Author

This might be off-topic, but I forked the repository and was looking for some other possible improvements, like making the window padding a preference and things like that, while trying to keep the preference list at a decent minimum. Would you like some collaborators and if so, what would be the next steps for Alt-Tab where I could contribute?

@lwouis
Copy link
Owner

lwouis commented May 21, 2020

Hey @hassanalinali! Collaboration is very welcomed on this project!

There is no clear roadmap at the moment. Feel free to tackle any open issue. As the app is getting more robust and mature, there are only a few bugs remaining. I had in mind to prioritize these 2, as they have the most conversation happening:

That being said, they may be quite challenging for a newcomer to the project. Some other tickets would be much easier for sure. As I said, feel free to pick any ticket you have personal interest in.

Regarding this current ticket, and the you mentioning adding another preference for window padding: I'm read complaints from people that the current preferences are too overwhelming. Imagine you open it the first time, you see 20 sliders and checkboxes, and just close it immediately.

I think I'll open a ticket soon to discuss how this can be improved. It's very challenging to keep the app flexible, while keeping its preferences reasonable. One way to do it is to have "normal" and "expert" modes. Normal mode would be macro preferences wherein each choice corresponds to a set of preferences (e.g. "macOS theme" = no borders, black background, rounded corners, etc). You could then switch to "expert" mode, and all the details would be exposed for maximum flexibility. It's quite a lot of work though, and I'm not a fan of these modes in general.

What I was more appealed by would be to introduce a richer UI for preferences where the preferences are communicated in a more visual manner. Let's say we split the preferences tabs more, and within the "layout" tab, you have a diagram representing AltTab main window, and if you move a slider like window padding or number of windows, you see the diagram update in real time, illustrating the change. It is quite a lot of work though, which is why I haven't done it yet.

Let me know if you decide to work on something, that way we avoid working on the same thing at the same time 👍

@lwouis lwouis removed the enhancement New feature or request label Jun 10, 2020
@LazarLazarov
Copy link

Hello, I also find the top-alignment to be more jarring than both center or bottom aligning. Ideally having a drop-down to choose the alignment would best, but I do also understand the issue of being overwhelmed with options. Would maybe adding an "Advanced options" checkbox that reveals such settings be a possible solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preference Introduction of a new preference
Projects
None yet
Development

No branches or pull requests

3 participants