From 822bf9c9ae61139508fb24ea0f244f0503e4a945 Mon Sep 17 00:00:00 2001 From: AMet <109765625+AMetIR@users.noreply.github.com> Date: Sat, 23 Jul 2022 12:47:18 -0700 Subject: [PATCH 1/2] Fixed grammar errors in README.md --- README.mdown | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/README.mdown b/README.mdown index fc67ca464..cbb46b60d 100644 --- a/README.mdown +++ b/README.mdown @@ -3,7 +3,7 @@ About Walk Walk is a "Windows Application Library Kit" for the Go Programming Language. -Its primarily useful for Desktop GUI development, but there is some more stuff. +It is primarily useful for Desktop GUI development, but there is some more stuff. Setup ===== @@ -20,7 +20,7 @@ Now run `go get github.com/lxn/walk` Using Walk ========== -The preferred way to create GUIs with Walk is to use its declarative sub package, +The preferred way to create GUIs with Walk is to use its declarative subpackage, as illustrated in this small example: ##### `test.go` @@ -92,7 +92,7 @@ In the directory containing `test.go` run go build -To get rid of the cmd window, instead run +To get rid of the cmd window, instead, run go build -ldflags="-H windowsgui" @@ -120,7 +120,7 @@ To embed a manifest file as a resource, you can use the [rsrc tool](https://gith IMPORTANT: If you don't embed a manifest as a resource, then you should not launch your executable before the manifest file is in place. If you do anyway, the program will not run properly. And worse, Windows will not -recognize a manifest file, you later drop next to the executable. To fix this, +recognize a manifest file, which you later drop next to the executable. To fix this, rebuild your executable and only launch it with a manifest file in place. CGo Optimizations @@ -128,6 +128,6 @@ CGo Optimizations The usual default message loop includes calls to win32 API functions, which incurs a decent amount of runtime overhead coming from Go. As an alternative to this, you may compile Walk using an -optional C implementation of the main message loop, by passing the `walk_use_cgo` build tag: +optional C implementation of the main message loop, bypassing the `walk_use_cgo` build tag: go build -tags walk_use_cgo From 77b429f84ba54094366451bb4bc406f6ce099b2c Mon Sep 17 00:00:00 2001 From: AMet <109765625+AMetIR@users.noreply.github.com> Date: Sat, 23 Jul 2022 12:49:29 -0700 Subject: [PATCH 2/2] Update README.mdown --- README.mdown | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.mdown b/README.mdown index cbb46b60d..901cdf665 100644 --- a/README.mdown +++ b/README.mdown @@ -128,6 +128,6 @@ CGo Optimizations The usual default message loop includes calls to win32 API functions, which incurs a decent amount of runtime overhead coming from Go. As an alternative to this, you may compile Walk using an -optional C implementation of the main message loop, bypassing the `walk_use_cgo` build tag: +optional C implementation of the main message loop, by passing the `walk_use_cgo` build tag: go build -tags walk_use_cgo