fix: apply active class to submenu items #350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the issue fixed here
Recently support for dropdown has been implemented in navigation menu, ref. #344 . There's a small issue there that the menu section will not be underlined as active if any menu options other than the first one will be chosen from the dropdown. So in exampleSite if you had a structure like this:
Then Accomplishments section will be marked as active only if Awards is an active page but not when Certifications is an active page.
This has now been fixed and parent section will be marked as active as long as any of the child sections are currently active.
Issue Number:
Additional Information (Optional)
Checklist
Yes, I included all necessary artefacts, including:
Testing Checklist
Yes, I ensured that all of the following scenarios were tested:
Notify the following users
@lxndrblz