Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply active class to submenu items #350

Merged

Conversation

guidemetothemoon
Copy link
Contributor

Description

Describe the issue fixed here
Recently support for dropdown has been implemented in navigation menu, ref. #344 . There's a small issue there that the menu section will not be underlined as active if any menu options other than the first one will be chosen from the dropdown. So in exampleSite if you had a structure like this:

Accomplishments:
    Awards
    Certifications

Then Accomplishments section will be marked as active only if Awards is an active page but not when Certifications is an active page.
This has now been fixed and parent section will be marked as active as long as any of the child sections are currently active.

Issue Number:

  • Here Goes the Issue Number with a '#'

Additional Information (Optional)

  • Here goes any Additional Information you would like to add.

Checklist

Yes, I included all necessary artefacts, including:

  • Tests
  • Documentation
  • Implementation (Code and Ressources)
  • Example

Testing Checklist

Yes, I ensured that all of the following scenarios were tested:

  • Desktop Light Mode (Default)
  • Desktop Dark Mode
  • Desktop Light RTL Mode
  • Desktop Dark RTL Mode
  • Mobile Light Mode
  • Mobile Dark Mode
  • Mobile Light RTL Mode
  • Mobile Dark RTL Mode

Notify the following users

  • List users with @ to send Notifications
    @lxndrblz

@netlify
Copy link

netlify bot commented Apr 23, 2022

Deploy Preview for anatole-demo ready!

Name Link
🔨 Latest commit bf76b3f
🔍 Latest deploy log https://app.netlify.com/sites/anatole-demo/deploys/626d05fc2eab48000797394c
😎 Deploy Preview https://deploy-preview-350--anatole-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@guidemetothemoon guidemetothemoon marked this pull request as ready for review April 23, 2022 13:17
@guidemetothemoon guidemetothemoon changed the title Fix/apply active to all children fix: Apply active link class to parent menu section in case any of the children sections are chosen from the dropdown menu Apr 23, 2022
@lxndrblz lxndrblz changed the title fix: Apply active link class to parent menu section in case any of the children sections are chosen from the dropdown menu fix: apply active class to submenu items Apr 30, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lxndrblz lxndrblz merged commit ec5066b into lxndrblz:master Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants