Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing on invalid URI #483

Closed
tjperry07 opened this issue Jan 28, 2022 · 3 comments
Closed

Failing on invalid URI #483

tjperry07 opened this issue Jan 28, 2022 · 3 comments

Comments

@tjperry07
Copy link

tjperry07 commented Jan 28, 2022

If it encounters an invalid URI, it would be nice if it just returned it as an error instead of failing the entire link check itself.

Further research, it failed on an iframe link. I set it to exclude the link --exclude www.loom.com --exclude https://www.loom.com --exclude loom.com but it still picks up in it. The link is valid.

thread 'tokio-runtime-worker' panicked at 'a parsed Url should always be a valid Uri: InvalidUri(InvalidUriChar)', /Users/brew/Library/Caches/Homebrew/cargo_cache/registry/src/git.luolix.top-1ecc6299db9ec823/reqwest-0.11.8/src/into_url.rs:70:14
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'Cannot send request: SendError(Ok(Request { uri: Uri { url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("www.loom.com")), port: None, path: "/embed/6982a6dd9a984765b9c7c969a40af06e", query: None, fragment: None } }, source: FsPath("src/docs/user-experience/scheduler/creating-and-scheduling/schedule-editor.md"), element: N✔ https://docs.nylas.com/reference#account-sync-status [200 OK]

@mre
Copy link
Member

mre commented Jan 28, 2022

This is a known issue in reqwest and there is an open pull request for it: seanmonstar/reqwest#1399. Sadly very little traction.

We might want to support different http clients in the future like isahc, attohttpc, surf, or h2.

@tjperry07
Copy link
Author

Thanks for letting me know. I'll close this one since there is already an issue open.

@tjperry07
Copy link
Author

Also related seanmonstar/reqwest#668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants