Skip to content

Commit

Permalink
Update util/oidc/oidc.go
Browse files Browse the repository at this point in the history
Better phrasing.

Co-authored-by: Blake Pettersson <blake.pettersson@gmail.com>
Signed-off-by: Kevin Lyda <kevin@ie.suberic.net>
Signed-off-by: Kevin Lyda <kevin@lyda.ie>
  • Loading branch information
lyda and blakepettersson committed Mar 28, 2024
1 parent f4eddc0 commit 6793066
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion util/oidc/oidc.go
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ func (a *ClientApp) HandleLogin(w http.ResponseWriter, r *http.Request) {
returnURL := r.FormValue("return_url")
// Check if return_url is valid, otherwise abort processing (see https://github.com/argoproj/argo-cd/pull/4780)
if !isValidRedirectURL(returnURL, []string{a.settings.URL}) {
log.Errorf("Invalid redirect URL: %s is not a valid per the settings.", returnURL)
log.Errorf("Invalid redirect URL: %s is not a valid URL or does not match the URL in settings.", returnURL)
http.Error(w, "Invalid redirect URL: the protocol and host (including port) must match and the path must be within allowed URLs if provided", http.StatusBadRequest)
return
}
Expand Down

0 comments on commit 6793066

Please sign in to comment.