-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add oauth support to gsuite #1071
Conversation
@achantavy linter issues should be fixed now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Left some nits and questions but overall looks good to me.
Co-authored-by: Alex Chantavy <achantavy@lyft.com>
Co-authored-by: Alex Chantavy <achantavy@lyft.com>
Co-authored-by: Alex Chantavy <achantavy@lyft.com>
Co-authored-by: Alex Chantavy <achantavy@lyft.com>
added a small fix :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
Just gotta remove a whitespace and remove the |
My bad I did not run pre-commit check localy after this small edit. Will fix lint and unit test tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Allow gsuite to use oauth credentials.
Legacy method is used by default for backward compatibility.