Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add oauth support to gsuite #1071

Merged
merged 11 commits into from
Jan 13, 2023
Merged

feat: add oauth support to gsuite #1071

merged 11 commits into from
Jan 13, 2023

Conversation

jychp
Copy link
Collaborator

@jychp jychp commented Jan 5, 2023

Allow gsuite to use oauth credentials.

Legacy method is used by default for backward compatibility.

@jychp
Copy link
Collaborator Author

jychp commented Jan 6, 2023

@achantavy linter issues should be fixed now

Copy link
Contributor

@achantavy achantavy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Left some nits and questions but overall looks good to me.

docs/root/modules/gsuite/config.md Outdated Show resolved Hide resolved
docs/root/modules/gsuite/config.md Outdated Show resolved Hide resolved
docs/root/modules/gsuite/config.md Outdated Show resolved Hide resolved
docs/root/modules/gsuite/config.md Outdated Show resolved Hide resolved
docs/root/modules/gsuite/config.md Outdated Show resolved Hide resolved
cartography/intel/gsuite/__init__.py Outdated Show resolved Hide resolved
cartography/intel/gsuite/__init__.py Show resolved Hide resolved
cartography/intel/gsuite/__init__.py Outdated Show resolved Hide resolved
cartography/intel/gsuite/__init__.py Outdated Show resolved Hide resolved
cartography/intel/gsuite/__init__.py Show resolved Hide resolved
jychp and others added 5 commits January 9, 2023 09:16
Co-authored-by: Alex Chantavy <achantavy@lyft.com>
Co-authored-by: Alex Chantavy <achantavy@lyft.com>
Co-authored-by: Alex Chantavy <achantavy@lyft.com>
Co-authored-by: Alex Chantavy <achantavy@lyft.com>
@jychp
Copy link
Collaborator Author

jychp commented Jan 9, 2023

added a small fix :

        ON CREATE SET
        u.firstseen = $UpdateTag
        ON MATCH SET u.user_id = user.id,
        u.agreed_to_terms = user.agreedToTerms,

ON MATCH SET will prevent data population on first run, replaced by SET

@jychp jychp requested review from achantavy and removed request for mpurusottamc January 9, 2023 16:43
achantavy
achantavy previously approved these changes Jan 11, 2023
Copy link
Contributor

@achantavy achantavy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@achantavy
Copy link
Contributor

Just gotta remove a whitespace and remove the on match set and I think the CI will pass

@jychp
Copy link
Collaborator Author

jychp commented Jan 11, 2023

Just gotta remove a whitespace and remove the on match set and I think the CI will pass

My bad I did not run pre-commit check localy after this small edit. Will fix lint and unit test tomorrow.

Copy link
Contributor

@achantavy achantavy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

cartography/cli.py Outdated Show resolved Hide resolved
@jychp jychp requested a review from achantavy January 13, 2023 14:55
@achantavy achantavy merged commit 75a032c into cartography-cncf:master Jan 13, 2023
@jychp jychp deleted the gsuite_oauth branch January 13, 2023 17:45
chandanchowdhury pushed a commit to juju4/cartography that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants