Fix #1289 EC2 get_images_in_use() failed with CypherSyntaxError when using Neo4J 5.16.0 #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvasilevich
force-pushed
the
bugfix-1289
branch
from
e2db9be
to
4d88e22
Compare
…yntaxError when using Neo4J 5.16.0
pvasilevich
force-pushed
the
bugfix-1289
branch
from
4d88e22
to
34b5d63
Compare
achantavy
approved these changes
Mar 21, 2024
| WHERE ltv.region = $Region | ||
| WITH collect(DISTINCT ltv.image_id)+images AS images | ||
| RETURN images |
There was a problem hiding this comment.
To make sure I understand
(comment 1) If I understand correctly, this originally returns a list of image ids in a field called images.
| WHERE ltv.region = $Region | ||
| WITH collect(DISTINCT ltv.image_id)+images AS images | ||
| RETURN images | ||
| RETURN DISTINCT(ltv.image_id) as image |
There was a problem hiding this comment.
(comment 2) .. and this new code returns a list of image id strings without needing to put it in a field of any sort
| """ | ||
| results = neo4j_session.run(get_images_query, AWS_ACCOUNT_ID=current_aws_account_id, Region=region) | ||
| images = [] | ||
| for r in results: | ||
| images.extend(r['images']) | ||
| images.append(r['image']) |
There was a problem hiding this comment.
(comment 3) and because of that we can simply append to the existing array instead of extend
chandanchowdhury
pushed a commit
to juju4/cartography
that referenced
this pull request
Jun 26, 2024
…yntaxError when using Neo4J 5.16.0 (cartography-cncf#1290)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.