Optimize image pushes and integration tests #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandswaminathan
force-pushed
the
Docker_build_integration
branch
from
4d915b5
to
aa836d4
Compare
anandswaminathan
force-pushed
the
Docker_build_integration
branch
from
db17e35
to
ce5b98c
Compare
anandswaminathan
changed the title
mwylde
approved these changes
May 31, 2019
integ/main_test.go
Outdated
| // var image = flag.String("image", "lyft/flinkk8soperator:latest", "image for the operator") | ||
| var image = os.Getenv("OPERATOR_IMAGE") | ||
| // var image = flag.String("image", "flinkk8soperator:latest", "image for the operator") | ||
| var image = os.Getenv("IMAGE") |
There was a problem hiding this comment.
I think OPERATOR_IMAGE is clearer, as there are several different images involved.
There was a problem hiding this comment.
Yes. The documentation was IMage. Will change to Operator_image everywhere
There was a problem hiding this comment.
Yeah, I forgot to update the doc when I changed it a while back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make images to be pushed only after merging to master. Integration tests will build images, and use the locally built images to run tests.
We can in future make images to be pushed to dockerhub on successful PR if needed.