From c715a43610202a977b1d8c02a27f86e615a8c7be Mon Sep 17 00:00:00 2001 From: timifasubaa <30888507+timifasubaa@users.noreply.github.com> Date: Tue, 11 Sep 2018 17:23:44 -0700 Subject: [PATCH] fix sqllab logging (#5862) --- superset/sql_lab.py | 2 +- superset/views/core.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/superset/sql_lab.py b/superset/sql_lab.py index fff42718c0f36..8e2cafcd97d80 100644 --- a/superset/sql_lab.py +++ b/superset/sql_lab.py @@ -100,7 +100,7 @@ def execute_sql( user_name=None, session=None, start_time=None, ): """Executes the sql query returns the results.""" - if store_results: + if store_results and start_time: # only asynchronous queries stats_logger.timing( 'sqllab.query.time_pending', utils.now_as_float() - start_time) diff --git a/superset/views/core.py b/superset/views/core.py index e0260d17bfc1b..e021709434419 100755 --- a/superset/views/core.py +++ b/superset/views/core.py @@ -2338,7 +2338,7 @@ def results(self, key): blob = results_backend.get(key) stats_logger.timing( 'sqllab.query.results_backend_read', - read_from_results_backend_start - utils.now_as_float(), + utils.now_as_float() - read_from_results_backend_start, ) if not blob: return json_error_response(