From cb4a44ecb79883652cb46ab0c50865eaab3d136d Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Mon, 10 Sep 2018 23:01:34 -0700 Subject: [PATCH] [bugfix] 'No numeric types to aggregate' in NVD3 chart (#5853) (cherry picked from commit 73cfcccf050d71f13edc88b330ef6433ebad7ff4) --- superset/viz.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/superset/viz.py b/superset/viz.py index 1f1f79c2c020f..2e76c88fce5e0 100644 --- a/superset/viz.py +++ b/superset/viz.py @@ -227,15 +227,15 @@ def get_df(self, query_obj=None): df[DTTM_ALIAS] += self.time_shift if self.enforce_numerical_metrics: - self.df_metrics_to_num(df, query_obj.get('metrics') or []) + self.df_metrics_to_num(df) df.replace([np.inf, -np.inf], np.nan) df = self.handle_nulls(df) return df - @staticmethod - def df_metrics_to_num(df, metrics): + def df_metrics_to_num(self, df): """Converting metrics to numeric when pandas.read_sql cannot""" + metrics = self.metric_labels for col, dtype in df.dtypes.items(): if dtype.type == np.object_ and col in metrics: df[col] = pd.to_numeric(df[col], errors='coerce')