Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render_create_success should return 201 code not 200? #516

Closed
Fedcomp opened this issue Jan 29, 2016 · 1 comment
Closed

render_create_success should return 201 code not 200? #516

Fedcomp opened this issue Jan 29, 2016 · 1 comment

Comments

@Fedcomp
Copy link

Fedcomp commented Jan 29, 2016

When i register using api, i expect it to be restful and receive 201 code if register was successful.
However, render_create_success does not set response code, so it stays 200.
Why is it important at all? well, for example i use rack-minitest, and it has convenient methods like assert_created which expect response to return 201. The method itself

Yes i know, i can redefine methods with my own controller, however i think 201 on success should be default behavior.

@zachfeldman
Copy link
Contributor

Nobody else seems to have a problem with this in the last 1.5 years so I'm going to close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants