Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go-metrics extensively #27

Open
schmichael opened this issue Oct 6, 2014 · 3 comments
Open

Use go-metrics extensively #27

schmichael opened this issue Oct 6, 2014 · 3 comments

Comments

@schmichael
Copy link
Contributor

Instrument everything

Alternatively we could use go's builtin lightweight expvar and httpprof.

@epsniff
Copy link
Contributor

epsniff commented Oct 6, 2014

Im all for limiting dependencies. Can we use expvar without automatically exposing it via HTTP? IMO, surfacing the metrics should be left to the hosting project.

@schmichael
Copy link
Contributor Author

@epsniff

Can we use expvar without automatically exposing it via HTTP?

You don't have to start the HTTP server, but it does register its endpoints on the default HTTP server mux. You can't change that without forking it like I did with https://github.com/lytics/httppprof

However, in hindsight it seems like using the default HTTP server mux for debugging/monitoring is idiomatic, so I'm actually leaning towards just enabling both libraries by default.

@epsniff
Copy link
Contributor

epsniff commented Oct 6, 2014

I'm ok with that, so long as it doesn't turn on the http server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants