New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Same node could reclaim a lost task #50

Open

schmichael opened this issue Oct 16, 2014 · 0 comments

Labels

Contributor

schmichael commented Oct 16, 2014

Scenario to test:

Node is under load and doesn't refresh a Task before TTL expires.
Node's Watcher claims newly released Task (before refresh CAS is attempted).

If this happens there are a few things that could happen:

2 refreshers are started for the claim key... this actually wouldn't hurt anything AFAICT, just be very strange.
The consumer will refuse to start the new task because it's already running that task.

So while there could be some strange errors and a needless restart of a task, it shouldn't be fatal to the node or task.

Needs a test.

schmichael added etcd test labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment