Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support whisper max line width/count option #175

Closed
ahobsonsayers opened this issue Apr 11, 2023 · 2 comments
Closed

Support whisper max line width/count option #175

ahobsonsayers opened this issue Apr 11, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@ahobsonsayers
Copy link

ahobsonsayers commented Apr 11, 2023 •
edited
Loading

Whisper recently added support for max line width and max line count. See openai/whisper#1184

This is very useful because for English, Amara.org and Netflix suggest it's best to keep subtitles to 42 characters per line. You can read more about the discussions surrounding this topic here openai/whisper#314

It would be really great is whisperx could add support for these options!
@m-bain m-bain added the enhancement New feature or request label Apr 11, 2023
@m-bain
Copy link
Owner

m-bain commented May 1, 2023

supported in v3

@m-bain m-bain closed this as completed May 1, 2023
@ahobsonsayers
Copy link
Author

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahobsonsayers @m-bain