Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please also build an sdist for PyPI #6

Closed
smith120bh opened this issue Jul 8, 2024 · 0 comments · Fixed by #7
Closed

Please also build an sdist for PyPI #6

smith120bh opened this issue Jul 8, 2024 · 0 comments · Fixed by #7

Comments

@smith120bh
Copy link
Contributor

smith120bh commented Jul 8, 2024

First off - I love that you've done this. Thank you so much! I was looking to do something similar myself in rebuilding triangle to work correctly on multiple architectures, but just did not have time to get to it, and you've done a more careful job than I would have.

I would like to request that you also upload an sdist source distribution to PyPI. While the wheels you're building cover almost all cases that someone might want, they don't quite cover everything. We have a case where we're running a docker container of a linux distribution on MacOS arm64 machines - so technically need a manylinux/arm64 wheel. It's probably a waste for you to build those wheels in your GitHub Action here, but if you include a source distribution then anyone can build whatever weird combinations of Python/OS/arch that might work.

I'm also happy to PR a patch to do this :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant