Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick checks #64

Open
7 of 8 tasks
m-clark opened this issue May 27, 2024 · 4 comments
Open
7 of 8 tasks

Quick checks #64

m-clark opened this issue May 27, 2024 · 4 comments
Assignees

Comments

@m-clark
Copy link
Owner

m-clark commented May 27, 2024

From our discussion:

Code:

GLM

  • Review GLM chap suggestions #59 as well as the changes that have been made to see if up to snuff
  • Let's move any 'by-hand' models that were in GLM and extensions to a new appendix doc that will be available in the web version only.

Other

  • Update any figs you come across to save the figure and use so it will work for pdf. Maybe we should just do that as default instead of conditional, but doing it that way would allow us to do grayscale for pdf specifically.
  • Also, I figured out how to do that annotated equation stuff. It requires that package, and does not appear to work for html. But I tried it in the current conclusion chapter with success, and just took a screenshot for html. I think the colors/text should print fine if the text is as at least dark enough. I would like to update the linear model chapter with this stuff at some point. Feel free to take a shot. Might be useful for class stuff too.
@saberry
Copy link
Collaborator

saberry commented May 28, 2024

I've started throwing the full links into the code, @m-clark, but they are very likely going to run into the margins (in addition to not being too friendly to type). Is changing them over to a tiny url okay?

@m-clark
Copy link
Owner Author

m-clark commented May 28, 2024

Yeah, definitely have to watch out for that, we have several pain points on code getting into the margins remaining even after I've tried to catch most, so best not to add to it. I'll add the raw url to the dataset descriptions in the appendix (which is up to date but not pushed yet)

@m-clark
Copy link
Owner Author

m-clark commented Jun 3, 2024

Side note: the problem with title spacing on tbl/fig captions was due to a single table (in glm chapter) that had a label but no caption. Every thing was fine before that and incorrectly spaced after. Giving it a title fixes the problem.

@m-clark
Copy link
Owner Author

m-clark commented Nov 21, 2024

Let's move any 'by-hand' models that were in GLM and extensions to a new appendix doc that will be available in the web version only.

I'd forgotten about this but on revisiting think it may still be a good idea. Initially the 'by-hand' was going to be the focus, but I'm not as convinced it's as useful in the current. However, we condensed the GLM stuff to one demo. We also dropped the additive (which is available in my other doc) and mixed (which I've never felt has an intuitive/simple approach), leaving only the quantile, which is an easy demo similar to GLM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants