From 30cfd987925a6e9a3f16c8a49dc87c171a5d8521 Mon Sep 17 00:00:00 2001 From: Vytenis Darulis Date: Wed, 2 Dec 2020 22:05:50 -0500 Subject: [PATCH] [etcd] Log watch error source details (#2974) --- src/cluster/etcd/watchmanager/manager.go | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/cluster/etcd/watchmanager/manager.go b/src/cluster/etcd/watchmanager/manager.go index dc4a4ac6e8..518f0a2168 100644 --- a/src/cluster/etcd/watchmanager/manager.go +++ b/src/cluster/etcd/watchmanager/manager.go @@ -145,7 +145,13 @@ func (w *manager) Watch(key string) { // handle the update if err = r.Err(); err != nil { - logger.Error("received error on watch channel", zap.Error(err)) + logger.Error( + "received error on watch channel", + zap.Uint64("etcd_cluster_id", r.Header.ClusterId), + zap.Uint64("etcd_member_id", r.Header.MemberId), + zap.Bool("etcd_watch_is_canceled", r.Canceled), + zap.Error(err), + ) w.m.etcdWatchError.Inc(1) // do not stop here, even though the update contains an error // we still take this chance to attempt a Get() for the latest value